Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloning docs to reflect beta for 1.16 #16013

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Update cloning docs to reflect beta for 1.16 #16013

merged 1 commit into from
Sep 6, 2019

Conversation

j-griffith
Copy link
Contributor

@j-griffith j-griffith commented Aug 22, 2019 •
edited
Loading

Updates the feature status for VolumePVCDataSource to 1.16/beta in the
docs.

Associated KEP update: kubernetes/enhancements#1147

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 7effc78

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d6a7fc210bca20007a71f76

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2019
@j-griffith j-griffith mentioned this pull request Aug 22, 2019
Merged
@msau42
Copy link
Member

msau42 commented Aug 22, 2019

feature-gates.md also needs to be updated

msau42
msau42 reviewed Aug 22, 2019
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -174,7 +174,7 @@ different Kubernetes components.
| `TokenRequestProjection` | `false` | Alpha | 1.11 | 1.11 |
| `TokenRequestProjection` | `true` | Beta | 1.12 | |
| `TTLAfterFinished` | `false` | Alpha | 1.12 | |
| `VolumePVCDataSource` | `false` | Alpha | 1.15 | |
| `VolumePVCDataSource` | `true` | Beta | 1.16 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we add a new line for beta and keep the alpha entry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot, you're right fixed.

msau42
msau42 reviewed Aug 22, 2019
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -175,6 +175,7 @@ different Kubernetes components.
| `TokenRequestProjection` | `true` | Beta | 1.12 | |
| `TTLAfterFinished` | `false` | Alpha | 1.12 | |
| `VolumePVCDataSource` | `false` | Alpha | 1.15 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the "Until" column needs to be updated too :-)

msau42
msau42 reviewed Aug 22, 2019
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -174,7 +174,8 @@ different Kubernetes components.
| `TokenRequestProjection` | `false` | Alpha | 1.11 | 1.11 |
| `TokenRequestProjection` | `true` | Beta | 1.12 | |
| `TTLAfterFinished` | `false` | Alpha | 1.12 | |
| `VolumePVCDataSource` | `false` | Alpha | 1.15 | |
| `VolumePVCDataSource` | `false` | Alpha | 1.15 | 1.16 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think it's inclusive, so should be 1.15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, my fault completely, thanks for keeping me honest when I'm rushing.

@simplytunde
Copy link
Contributor

@j-griffith is this tied to any enhancement?

@msau42
Copy link
Member

msau42 commented Aug 22, 2019

/lgtm
/hold
until feature is merged

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 22, 2019
@zacharysarah
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 22, 2019
@j-griffith
Copy link
Contributor Author

j-griffith commented Aug 22, 2019 •
edited
Loading

@j-griffith is this tied to any enhancement?

@simplytunde Yes, associated with update of KEP (merged):
kubernetes/enhancements#1147

PR for the feature itself is here: kubernetes/kubernetes#81792

@msau42
Copy link
Member

msau42 commented Aug 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
msau42
msau42 reviewed Aug 29, 2019
View reviewed changes
content/en/docs/concepts/storage/volume-pvc-datasource.md
@@ -32,7 +32,7 @@ The {{< glossary_tooltip text="CSI" term_id="csi" >}} Volume Cloning feature add

A Clone is defined as a duplicate of an existing Kubernetes Volume that can be consumed as any standard Volume would be. The only difference is that upon provisioning, rather than creating a "new" empty Volume, the back end device creates an exact duplicate of the specified Volume.

The implementation of cloning, from the perspective of the Kubernetes API simply adds the ability to specify an existing unbound PVC as a dataSource during new pvc creation.
The implementation of cloning, from the perspective of the Kubernetes API simply adds the ability to specify an existing unbound PVC as a dataSource during new pvc creation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PVC example below doesn't specify a storageclass, but we made it required right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageClass is not actually required, it's just required that the source and destination are in the same storageClass. This can either be specified via storageClassName or by having a default storageClass.

I updated the doc to try and clarify that.

@msau42
Copy link
Member

msau42 commented Aug 29, 2019

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@j-griffith
Update cloning docs to reflect beta for 1.16
7effc78 
Updates the feature status for VolumePVCDataSource to 1.16/beta in the
docs.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2019
@msau42
Copy link
Member

msau42 commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@simplytunde
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.16 milestone Sep 5, 2019
@simplytunde
Copy link
Contributor

@j-griffith looks like the enhancement will be in 1.16. can you close this?

@msau42
Copy link
Member

msau42 commented Sep 5, 2019

Confused, this should be in 1.16 right?

We're waiting on docs to give a final review/approval

@simplytunde
Copy link
Contributor

sorry about that. Yes, it is still going into 1.16

@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Sep 6, 2019
@simplytunde
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 420afb2 into kubernetes:dev-1.16 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@j-griffith @k8sio-netlify-preview-bot @msau42 @simplytunde @zacharysarah @k8s-ci-robot