Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update window storage driver list with EBS #16300

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Update window storage driver list with EBS #16300

merged 1 commit into from
Sep 13, 2019

Conversation

leakingtapan
Copy link

@leakingtapan leakingtapan commented Sep 11, 2019 •
edited
Loading

Update window storage driver list with EBS as EBS windows support was fixed by kubernetes/kubernetes#79552

/cc @wongma7 @PatrickLang @michmike

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2019
@leakingtapan
Copy link
Author

/milestone 1.16

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 11, 2019
@netlify
Copy link

netlify bot commented Sep 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 46a8956

https://deploy-preview-16300--kubernetes-io-master-staging.netlify.com

@tengqm tengqm added this to the 1.16 milestone Sep 11, 2019
@michmike
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@michmike
Copy link
Contributor

are we supposed to check into master, or dev-1.16 instead?

@leakingtapan
Copy link
Author

Since 1.16 is not released yet, so I point it to master. Let me know which branch should I use @michmike

@simplytunde
Copy link
Contributor

@leakingtapan If this is going in with 1.16, this needs to be open against dev-1.16 and may need a rebase. Once this is done, I am happy to merge.

@michmike
Copy link
Contributor

i was going to say the exact same thing as @simplytunde . this should be in dev1.16

@leakingtapan leakingtapan changed the base branch from master to dev-1.16 September 12, 2019 17:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 12, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 0f8047a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d7a83bf6489f400082c9f68

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2019
@leakingtapan leakingtapan force-pushed the ebs-windows branch 2 times, most recently from 0b5cce1 to 0f8047a Compare September 12, 2019 17:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2019
@leakingtapan
Copy link
Author

@michmike rebased against dev-1.16 PTAL

@simplytunde
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@simplytunde
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michmike, simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit c999393 into kubernetes:dev-1.16 Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michmike michmike michmike approved these changes

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@michmike michmike

@simplytunde simplytunde

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@leakingtapan @k8s-ci-robot @michmike @simplytunde @k8sio-netlify-preview-bot @tengqm