Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote startupProbe to GA in 1.20 #23332

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Promote startupProbe to GA in 1.20 #23332

merged 1 commit into from
Oct 10, 2020

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Aug 22, 2020

Promote startupProbe to GA in 1.20
Related to kubernetes/kubernetes#94160

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2020
@matthyx
Copy link
Contributor Author

matthyx commented Aug 22, 2020

/assign @bradtopol

@netlify
Copy link

netlify bot commented Aug 22, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0964999

https://deploy-preview-23332--kubernetes-io-master-staging.netlify.app

sftim
sftim reviewed Aug 23, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

this PR needs to target the dev-1.20 branch (once it exists)

@matthyx sorry, you might have to wait on this one.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2020
@sftim
Copy link
Contributor

sftim commented Aug 23, 2020

BTW you will also need to edit https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

@matthyx
Copy link
Contributor Author

matthyx commented Aug 23, 2020

@matthyx sorry, you might have to wait on this one.

No problem, thanks for the heads up :)

@sftim
Copy link
Contributor

sftim commented Aug 27, 2020

We have a dev-1.20 branch. Please rebase against that @matthyx and change the merge-base to match.

@sftim
Copy link
Contributor

sftim commented Aug 27, 2020

Also, congratulations on being first out of the slips!

@matthyx matthyx changed the base branch from master to dev-1.20 August 28, 2020 08:41
@matthyx
Copy link
Contributor Author

matthyx commented Aug 28, 2020

We have a dev-1.20 branch. Please rebase against that @matthyx and change the merge-base to match.

Thanks, done!

@sftim
Copy link
Contributor

sftim commented Aug 28, 2020

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Aug 28, 2020
@sftim
Copy link
Contributor

sftim commented Aug 28, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2020
sftim
sftim previously requested changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthyx there's no metadata about feature state and graduation, so we maintain this list fairly manually.
I'm afraid this change isn't quite right; you need to amend the feature gates page as I've explained inline.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
| `StartupProbe` | `true` | Beta | 1.18 | |
| `StartupProbe` | `true` | Beta | 1.18 | 1.19 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong change I'm afraid.
The change you've made is right but, rather than replacing the line in place, keep it but move that amended line to the section https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features
then add a new line showing that it goes GA in v1.20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim done

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 6, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 0964999

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f7d630aa478ac000811097e

sftim
sftim reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown looks OK to me.

Which SIG owns this feature? That SIG should be able to give technical LGTM.

@matthyx
Copy link
Contributor Author

matthyx commented Sep 7, 2020

Which SIG owns this feature? That SIG should be able to give technical LGTM.

sig-node

@SergeyKanzhelev
Copy link
Member

Will this file be regenerated somehow or also need manual update?

https://github.com/kubernetes/website/blob/15f44cc421720cd14cc5b0e779a3c84e482e1733/content/en/docs/reference/command-line-tools-reference/kubelet.md

@matthyx matthyx mentioned this pull request Sep 12, 2020
Closed
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2020
@matthyx
Copy link
Contributor Author

matthyx commented Oct 7, 2020

@annajung I have corrected my rebase, could you please consider approving please?

@irvifa
Copy link
Member

irvifa commented Oct 7, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 7, 2020
@irvifa
Copy link
Member

irvifa commented Oct 7, 2020

Do we already have reviewer from sig node? @matthyx

@matthyx
Copy link
Contributor Author

matthyx commented Oct 7, 2020

Do we already have reviewer from sig node? @matthyx

The k/k PR has been merged already: kubernetes/kubernetes#94160
If you want I can ask for a LGTM...
/assign @SergeyKanzhelev

@annajung
Copy link
Contributor

annajung commented Oct 8, 2020

@kbhawkey @sftim @irvifa I think this PR lgtm and can be approved from my perspective. I don't think this it needs a tech review and has been vetted by docs team as well. Just wanted to confirm with you all before proceeding.

@sftim sftim dismissed their stale review October 8, 2020 21:37

Superseded

@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 9, 2020

Preview pages
https://deploy-preview-23332--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

https://deploy-preview-23332--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/pods/pod-lifecycle/#when-should-you-use-a-startup-probe

https://deploy-preview-23332--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/kubelet/

@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 9, 2020

The pages look good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ddc2ab397e69ea74cd62fafe8b20f7706eb6e385

irvifa
irvifa reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f2e72b into kubernetes:dev-1.20 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@sftim sftim sftim left review comments

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@kbhawkey kbhawkey

@bradtopol bradtopol

@SergeyKanzhelev SergeyKanzhelev

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
9 participants
@matthyx @sftim @k8sio-netlify-preview-bot @SergeyKanzhelev @kbhawkey @annajung @irvifa @k8s-ci-robot @bradtopol