Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cross-region ECR support #2359

Merged
merged 2 commits into from
Jan 26, 2017
Merged

Document cross-region ECR support #2359

merged 2 commits into from
Jan 26, 2017

Conversation

therc
Copy link
Member

@therc therc commented Jan 26, 2017

Fetching images from a registry hosted in a different region has been supported since 1.3 with
kubernetes/kubernetes#24369


This change is Reviewable

Fetching images from a registry hosted in a different region has been supported since 1.3 with
kubernetes/kubernetes#24369
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 26, 2017
@therc
Copy link
Member Author

therc commented Jan 26, 2017

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 26, 2017
@chenopis
Copy link
Contributor

@therc can you make a slight change and add an 'is' in the sentence, i.e. "If your nodes are in region A and your registry is in a different region B..." Thx

@chenopis
Copy link
Contributor

@therc Nevermind, I can add it in a separate change.

@chenopis chenopis merged commit 3a474df into kubernetes:master Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants