Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1.6 Upgrade notes to outline changes for etcd 3. #2763

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conversation

timothysc
Copy link
Member

@timothysc timothysc commented Mar 10, 2017

Fixes: #2172

/cc wojtek-t


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2017
@wojtek-t
Copy link
Member

@mml - FYI

This looks ok to me, but we need to extend this doc with the description how we recommend doing the upgrade. Though, we should probably merge this PR and do it in the next one (probably either @mml or myself).

Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two typos, then lgtm

* TOC
{:toc}

This document outlines the potentially distruptive changes that exist in the 1.6 release cycle. Operators, administrators, and developers should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: disruptive

$ kube-apiserver --storage-backend='etcd2' $(EXISTING_ARGS)
```

However, for longterm maintainance of the cluster, we recommend that the operator plan an outage window in order to perform a [v2->v3 data upgrade](https://coreos.com/etcd/docs/latest/upgrades/upgrade_3_0.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: maintenance

@timothysc
Copy link
Member Author

but we need to extend this doc with the description how we recommend doing the upgrade.

@wojtek-t I explicitly linked to the coreos docs on that part, but we could have a second on GCE/GKE using the script-ery too.

@wojtek-t
Copy link
Member

@timothysc - LGTM, though please fix travis - the failure seems related.

@timothysc
Copy link
Member Author

@wojtek-t DONE.

@wojtek-t wojtek-t self-assigned this Mar 13, 2017
@wojtek-t
Copy link
Member

/lgtm

@timothysc
Copy link
Member Author

@wojtek-t It looks like this needs an explicit merge.

@wojtek-t
Copy link
Member

@timothysc - oops sorry.

Can you please rebase and ping me?

@timothysc
Copy link
Member Author

@wojtek-t done.

@wojtek-t wojtek-t merged commit 617f0f7 into master Mar 15, 2017
@wojtek-t
Copy link
Member

@timothysc - done :)

@devin-donnelly
Copy link
Contributor

Why was this merged into Master before launch? This documentation has been published a week early, minimum.

@chenopis chenopis deleted the etcd3 branch March 28, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants