Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] sync endpoint-slices,persistent-volumes,topology-aware-hints #40016

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[zh] sync endpoint-slices,persistent-volumes,topology-aware-hints #40016

merged 1 commit into from
Mar 17, 2023

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Mar 15, 2023 •
edited
Loading

Related to task-3 of issue #39985.

content/en/docs/concepts/services-networking/endpoint-slices.md
content/zh-cn/docs/concepts/storage/persistent-volumes.md
content/en/docs/concepts/services-networking/topology-aware-hints.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2023
@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 115f9e7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/641323e7722072000721030b
😎 Deploy Preview https://deploy-preview-40016--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@asa3311 asa3311 changed the title [zh] sync endpoint-slices.md [zh] sync endpoint-slices,persistent-volumes Mar 15, 2023
@asa3311 asa3311 changed the title [zh] sync endpoint-slices,persistent-volumes [zh] sync endpoint-slices,persistent-volumes,topology-aware-hints Mar 15, 2023
@asa3311 asa3311 mentioned this pull request Mar 15, 2023
Closed
@windsonsea
Copy link
Member

You shall learn to squash your commits or you can read my notes.

@asa3311
Copy link
Contributor Author

asa3311 commented Mar 16, 2023

thanks @windsonsea ,I learn your notes.Now I squash commits in c9ef980。
Is that right?

@windsonsea
Copy link
Member

No. The number of commits shall be 1.

image

@asa3311 asa3311 force-pushed the zh]-sync-endpoint-slices.md branch 2 times, most recently from 42d6f20 to cee1258 Compare March 16, 2023 07:22
@k8s-ci-robot k8s-ci-robot added the language/de Issues or PRs related to German language label Mar 16, 2023
@asa3311 asa3311 force-pushed the zh]-sync-endpoint-slices.md branch 3 times, most recently from a55d54b to cd59904 Compare March 16, 2023 08:02
@asa3311
Copy link
Contributor Author

asa3311 commented Mar 16, 2023

@windsonsea ,Thanks,Now I squash commits to one,Is that right? please review.
Also, I would like to ask if there are any groups in this community? Can I join and learn?

@windsonsea
Copy link
Member

Thanks. You can join the slack channel by reading our contribution guide on kubernetes.io, especially:

@windsonsea
Copy link
Member

/remove-language de

@k8s-ci-robot k8s-ci-robot removed the language/de Issues or PRs related to German language label Mar 16, 2023
@windsonsea
Copy link
Member

/lgtm

Congrats!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b52f30d828ccbe345e59b234dc60e8d7082308d0

@howieyuen
Copy link
Member

CI job is failed, make a force push to retrigger

@howieyuen howieyuen mentioned this pull request Mar 16, 2023
Closed
5 tasks
@asa3311 asa3311 force-pushed the zh]-sync-endpoint-slices.md branch from cd59904 to 115f9e7 Compare March 16, 2023 14:12
@asa3311
Copy link
Contributor Author

asa3311 commented Mar 16, 2023

@howieyuen done

howieyuen
howieyuen reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howieyuen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit e9bfdf6 into kubernetes:main Mar 17, 2023
@asa3311 asa3311 mentioned this pull request Mar 20, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howieyuen howieyuen howieyuen left review comments

@kinzhi kinzhi Awaiting requested review from kinzhi

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asa3311 @windsonsea @k8s-ci-robot @howieyuen