Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document node authorization mode #4077

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 14, 2017

Docs for kubernetes/enhancements#279


This change is Reviewable

@liggitt liggitt added this to the 1.7 milestone Jun 14, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2017
@liggitt
Copy link
Member Author

liggitt commented Jun 14, 2017

@kubernetes/sig-auth-pr-reviews

@liggitt
Copy link
Member Author

liggitt commented Jun 14, 2017

/assign @chenopis

Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, otherwise lgtm


Kubelets must be able to read the API resources that describe the pods they are supposed to run,
read secrets, configmaps, persistent volume claims and persistent volumes related to those pods,
and write API objects that report the status of their pods, and of the node the kubelet is running on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is a awkward run-on sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made sense at midnight... will fix


In 1.8, the binding will not be created at all.

The `system:node` cluster role will continue to be created when using RBAC,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/when using RBAC/when using RBAC without the Node authorizer/g ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the role still gets created, just not the binding

Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor grammar and formatting nits

### Kubelets with undifferentiated usernames

In some deployments, kubelets have credentials that place them in the `system:nodes` group,
but do not identify the particular node they are associated with (have a username that does not match the `system:node:...` format).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edit: "...they are associated with, such as having a username that does not match the system:node:... format."

In some deployments, kubelets have credentials that place them in the `system:nodes` group,
but do not identify the particular node they are associated with (have a username that does not match the `system:node:...` format).

These kubelets would not be authorized by the `Node` authorization mode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be part of the previous paragraph.


If a cluster admin wishes to start using the `Node` authorizer and `NodeRestriction` admission plugin
to limit node access to the API, that can be done non-disruptively:
1. Enable the `Node` authorization mode (`--authorization-mode=Node,RBAC`) and the `NodeRestriction` admission plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bullet points aren't rendering correctly (see netlify preview). Try adding a newline between lines 57 and 58.


In 1.6, the `system:node` cluster role was automatically bound to the `system:nodes` group when using the [RBAC Authorization mode](/docs/admin/authorization/rbac/).

In 1.7, the automatic binding of the `system:nodes` group to the `system:node` role is deprecated,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the commas unnecessary: "In 1.7, the automatic binding of the system:nodes group to the system:node role is deprecated because the node authorizer accomplishes the same purpose with the benefit of additional restrictions on secret and configmap access."

@chenopis
Copy link
Contributor

@liggitt Ping me when the review comments have been addressed and this is ready to be merged. Thx

@chenopis
Copy link
Contributor

chenopis commented Jun 26, 2017

@liggitt FYI, all feedback must be addressed and LGTMs given by EOD Tue, June 27th so that this can be merged for the 1.7 release on June 28th.

@liggitt
Copy link
Member Author

liggitt commented Jun 27, 2017

@chenopis updated

@chenopis chenopis merged commit 97e1775 into kubernetes:release-1.7 Jun 27, 2017
@liggitt liggitt deleted the node-authz branch July 27, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants