Update some wording on kubeadm upgrades #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
requested review from
jbeda,
timothysc,
lukemarsden,
pipejakob and
chenopis
k8s-ci-robot
added
the
cncf-cla: yes
chenopis
suggested changes
Jul 5, 2017
| @@ -57,6 +57,10 @@ You need to have a Kubernetes cluster running version 1.6.x. | |||
|
|
|||
| 4. Perform kubeadm upgrade. | |||
|
|
|||
| **WARNING**: All parameters you passed to the first `kubeadm init` when you bootstrapped your | |||
| cluster **MUST** be specified here in the upgrade-`kubeadm init`-command. This is a limitation | |||
There was a problem hiding this comment.
suggested edit: "This is a limitation we plan to address in v1.8."
|
I think this is small enough to add Tech Review LGTM actually. I'll address the docs comment |
luxas
force-pushed
the
kubeadm_upgrade_notice
branch
from
e9c629b
to
5f52c69
Compare
|
@chenopis Reasonable to merge now in order to fix issues like kubernetes/kubeadm#333 ASAP? |
chenopis
approved these changes
Jul 5, 2017
|
Thanks! |
|
No prob. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cases like: kubernetes/kubeadm#333
/cc @jbeda @pipejakob @timothysc @lukemarsden @chenopis
This change is