Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Rephrase migration phase label for failed VMs under uncompleted Plan #1318

Conversation

sgratch
Copy link
Contributor

@sgratch sgratch commented Sep 5, 2024

Reference: #1277

When the plan status is not set yet as Failed but at least one VM under that plan was already failed to migrate, fix the phase status by changing it from "VM fail" to "Some VMs Failed" to be more clear.

Before

image

After

image

playing with window size:

Screencast.from.2024-09-08.16-14-40.webm

Note:
Please see suggestion for options 2 as a suggested status label: #1277 (comment)

Reference: kubev2v#1277

When the plan status is not set yet as failed but at least one VM under
that plan was failed to migrated already, change the phase status from
"vm fail" to "Some VMs Failed" to be more clear.

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@sgratch sgratch requested a review from yaacov September 5, 2024 15:22
@sgratch sgratch changed the title Rephrase migration phase label for failed VMs under uncompleted Plan 🐞 Rephrase migration phase label for failed VMs under uncompleted Plan Sep 5, 2024
@yaacov
Copy link
Member

yaacov commented Sep 8, 2024

can you add screenshots ?
since this is a 3 word status, i am concerned about how this will look on small screen, can you also add a screenshots with different screen widths ?

@yaacov yaacov added this to the 2.6.7 milestone Sep 8, 2024
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Sep 8, 2024
@sgratch
Copy link
Contributor Author

sgratch commented Sep 8, 2024

can you add screenshots ? since this is a 3 word status, i am concerned about how this will look on small screen, can you also add a screenshots with different screen widths ?

I added screenshots for the correlated issue with 2 options to concern:
#1277 (comment)
Please take a look.

I'll check with small screens/zoom in for the chosen option as well.

@yaacov
Copy link
Member

yaacov commented Sep 8, 2024

I added screenshots for the correlated issue with 2 options to concern:

nice, can you add the screenshots here ?
can you add here the screenshots of different width so we can see how the longer status string behave in different widths ?

@sgratch
Copy link
Contributor Author

sgratch commented Sep 8, 2024

can you add the screenshots here ?

Done. Added to main first comment.

can you add here the screenshots of different width so we can see how the longer status string behave in different widths

Done. It seems ok. In a specific very small width, the status icon is not aligned in some line with the label text, but this same behavior occurs with other statuses as well, so should be fixed in a follow up . E.g.
Screenshot from 2024-09-08 19-40-26

Screenshot from 2024-09-08 16-18-46

@yaacov yaacov merged commit 28eea5e into kubev2v:main Sep 8, 2024
7 checks passed
@sgratch sgratch deleted the rephrase-plan-phase-label-for-unfailed-plan-failed-vms branch September 9, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants