Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aerosouund to the KubeVirt org #3609

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

aerosouund
Copy link
Member

@aerosouund aerosouund commented Aug 28, 2024

GitHub Username: @aerosouund

Requirements

Sponsors

List of contributions to the KubeVirt project

  • PRs reviewed and/or authored
  • Issues responded to

Signed-off-by: Ammar Yasser <aerosound161@gmail.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 28, 2024
@kubevirt-bot
Copy link
Contributor

Hi @aerosouund. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@victortoso
Copy link
Member

+1
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@dhiller
Copy link
Contributor

dhiller commented Aug 28, 2024

/approve I am really happy to have you in the community, since your contributions to kubevirtci are a great step forward!

/hold for others to take a look also

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

+1 - @aerosouund has been doing some great work on kubevirtci

@acardace
Copy link
Member

/lgtm
Welcome and thank you for your amazing contributions so far!

@aerosouund
Copy link
Member Author

Thanks alot everyone ❤️

@brianmcarey
Copy link
Member

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@kubevirt-bot kubevirt-bot merged commit efbd5ee into kubevirt:main Aug 29, 2024
5 checks passed
chandramerla pushed a commit to chandramerla/project-infra that referenced this pull request Sep 6, 2024
Signed-off-by: Ammar Yasser <aerosound161@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants