Correct --config help string. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
ANeumann82,
asekretenko,
jmccormick2001 and
kaiwalyajoshi
as code owners
For example running `kubectl-kuttl-0.11.0 test tests/upgrade` in a directory with `kuttl-test.yaml` does not return in an error. Instead it loads the config and then overrides the `testDirs` with the command line argument. ``` 2021/09/09 09:42:02 kutt-test config testdirs is overridden with args: [ tests/upgrade ] ``` This is a common convention and quite useful. Signed-off-by: Marcin Owsiany <porridge@redhat.com>
porridge
force-pushed
the
porridge/config-help-fix
branch
from
6b4878e
to
28ad1ad
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For example running
kubectl-kuttl-0.11.0 test tests/upgradein a directory withkuttl-test.yamldoes not return in an error. Instead it loads the config and then overrides thetestDirswith the command line argument. This works regardless of whether an explicit--config kuttl-test.yamlis specified or not.This is a common convention and quite useful.