Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide YAML parsing errors. #324

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Do not hide YAML parsing errors. #324

merged 1 commit into from
Sep 15, 2021

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

Before:

$ echo '"error' | ./bin/kubectl-kuttl assert /dev/stdin 
Error: file "/dev/stdin" load yaml error
$

After:

$ echo '"error' | ./bin/kubectl-kuttl assert /dev/stdin 
Error: file "/dev/stdin" load yaml error: error decoding yaml /dev/stdin: error converting YAML to JSON: yaml: line 2: found unexpected end of stream
$

Fixes #323

Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgrm

agree! and thank you!

@kensipe kensipe merged commit c4037cf into main Sep 15, 2021
@kensipe kensipe deleted the porridge/dont-hide-errors branch September 15, 2021 18:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kuttl assert hides YAML parsing error messages
2 participants