-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a folder when it doesn't exist and is needed for the report #326
Conversation
One of the contributing steps is:
Where can I sign it? Thanks! |
@iblancasa 👋 You'll need to sign your commits to comply with the DCO found here Here's the document on how to sign commits for Github: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Edit: Linked to DCO rather than the CNCF CLA. |
Signed-off-by: Israel Blancas <iblancas@redhat.com>
9b2ae2d
to
74c9c28
Compare
Hi @kaiwalyajoshi, it seems I fixed the problem signing the commits :) Thanks! |
Is there anything else I can do to include this change? Thanks! |
this has been hanging out there a while... apologies! looking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a min, could you shorten the err var name. and consider if other errors are important to return (which will drive if it is reasonable to "reuse" the err
var.
I'll be quick on re-review. Thanks for the contribution!
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@kensipe thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm somewhat anti- elseif in go. what do you think of:
_, err := os.Stat(dir)
switch {
case os.IsNotExist(err):
err = os.MkdirAll(dir, 0755)
if err != nil {
return err
}
case err != nil:
return nil
}
I'm good either way. Expecting that a day will give thinking / response time. Will merge in either state tomorrow.
and thanks for the contribution! for awareness... Looking to do a release end of this week with go 1.17 bump and this change. |
@kensipe awesome! Thanks |
…udobuilder#326) Signed-off-by: Israel Blancas <iblancas@redhat.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas iblancas@redhat.com
Fixes #325