Test Report Dir Bug Fix #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
iblancasa
approved these changes
Apr 21, 2022
erikgb
reviewed
Apr 21, 2022
| @@ -241,6 +236,19 @@ func (ts *Testsuites) Report(dir, name string, ftype Type) error { | |||
| } | |||
| } | |||
|
|
|||
| func ensureDir(dir string) error { | |||
There was a problem hiding this comment.
Wouldn't it be easier if this func just had an early exit if dir == ""? To avoid the nesting in the calling func.
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
erikgb
reviewed
Apr 21, 2022
pkg/report/report.go
Outdated
| @@ -241,6 +234,20 @@ func (ts *Testsuites) Report(dir, name string, ftype Type) error { | |||
| } | |||
| } | |||
|
|
|||
| func ensureDir(dir string) error { | |||
| if dir != "" { | |||
There was a problem hiding this comment.
Suggested change
| if dir != "" { | |
| if dir == "" { |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
iblancasa
pushed a commit
to iblancasa/kuttl
that referenced
this pull request
Jul 20, 2022
A newly added feature was to create the directory for test reports if it didn't exist. The default if not specified location of the test report was "", which equated to the current directory. The check on "" existence was false which lead to the mkdir "" which is obvious going to fail. The solution is to verify that the artifactsDir isn't "" prior to that logic. Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
pushed a commit
to iblancasa/kuttl
that referenced
this pull request
Nov 17, 2022
A newly added feature was to create the directory for test reports if it didn't exist. The default if not specified location of the test report was "", which equated to the current directory. The check on "" existence was false which lead to the mkdir "" which is obvious going to fail. The solution is to verify that the artifactsDir isn't "" prior to that logic. Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A newly added feature was to create the directory for test reports if it didn't exist. The default if not specified location of the test report was "", which equated to the current directory. The check on "" existence was false which lead to the
mkdir ""which is obvious going to fail. The solution is to verify that the artifactsDir isn't "" prior to that logic.Thanks to the community Erik and @iblancasa for helping discover and track down so quickly. We will be getting a patch release out today.
Signed-off-by: Ken Sipe kensipe@gmail.com