Improve error message for test assertions #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need [this commit](kubernetes-sigs/controller-runtime@3a037ef) for the subsequent changes which invoke List() on the fake client. Signed-off-by: Marcin Owsiany <porridge@redhat.com>
In the test cases for multiple objects we're using NewV1Pod, which returns an actual Pod struct, rather than NewPod (which returns an Unstructured). This is because the fake client is unable to List() pods which were supplied to builder as Unstructureds. Instead it errors out with: item[0]: can't assign or convert unstructured.Unstructured into v1.Pod Signed-off-by: Marcin Owsiany <porridge@redhat.com>
porridge
force-pushed
the
verbose-error-nice
branch
from
18196a3
to
b0a7ac9
Compare
iblancasa
approved these changes
Aug 22, 2022
kensipe
approved these changes
Aug 25, 2022
|
apologies @porridge. my delay in getting to PRs had me merge an earlier PR which had collisions on the dependency in go.mod. I will handle the conflict if you don't have time. Ready to merge after all is resolved |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
iblancasa
pushed a commit
to iblancasa/kuttl
that referenced
this pull request
Nov 17, 2022
* Bump controller-runtime to pick up a fake client fix. We need [this commit](kubernetes-sigs/controller-runtime@3a037ef) for the subsequent changes which invoke List() on the fake client. * Improve error message for error assertions and add test. In the test cases for multiple objects we're using NewV1Pod, which returns an actual Pod struct, rather than NewPod (which returns an Unstructured). This is because the fake client is unable to List() pods which were supplied to builder as Unstructureds. Instead it errors out with: item[0]: can't assign or convert unstructured.Unstructured into v1.Pod Co-authored-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Marcin Owsiany <porridge@redhat.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With a test case such as this:
The result is:
Before this change:
which is not terribly useful for debugging..
After this change:
Getting information about the name of the matched resource was instrumental for solving the issue described in https://github.com/porridge/config-race-repro
See descriptions of individual commits for details.
Fixes: #371