fix: prefer events v1 over v1beta1 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
requested review from
kensipe,
asekretenko and
kaiwalyajoshi
as code owners
|
Also fixes #414 |
iblancasa
suggested changes
Nov 10, 2022
| t.Logger.Log("Trying with events eventsv1 API...") | ||
| err = t.collectEventsV1(cl, namespace) | ||
| t.Logger.Log("Trying with events eventsv1beta1 API...") | ||
| err = t.collectEventsBeta1(cl, namespace) | ||
| if err != nil { | ||
| t.Logger.Log("Trying with events corev1 API...") |
There was a problem hiding this comment.
Should the log message be changed?
There was a problem hiding this comment.
I changed the log message according to the logic change.
eddycharly
requested review from
iblancasa
and removed request for
kensipe,
kaiwalyajoshi and
asekretenko
iblancasa
pushed a commit
to iblancasa/kuttl
that referenced
this pull request
Nov 17, 2022
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR gives preference to events v1 over v1beta1 and falls back to v1beta1 if v1 didn't work.
Fixes #373
Fixes #414