fall back to controller-runtime defaulting for the apiserver #436
Conversation
redradrat
requested review from
kensipe,
asekretenko and
kaiwalyajoshi
as code owners
Signed-off-by: Ralph Kühnert <kuehnert.ralph@gmail.com>
redradrat
force-pushed
the
upstream-mock-controlplane-defaulting
branch
from
e1e9540
to
66f2ecc
Compare
|
looks like a number of PRs coming working on the same area of code... I will review this today. thanks @redradrat ! |
|
I was just recently upgrading testenv libs and was debating on this... I was debating on if we should detect version and configure based on that providing tests for different versions of APIs... It seems reasonable to move on, establish ourselves on the latest and handle any issues if they come up... it is unlikely and the only reason I can think of to support older versions is for v1beta1 support of CRDs... but that was so long ago now. Thanks for this PR. I will merge this and adjust my current code accordingly. Agree with the the overhaul on config at some point. Thanks so much! |
|
@kensipe tbh I don't know the reason either... I wrote this so brain-fried after long hours - I even forgot sending it at all 😅 sorry |
What this PR does / why we need it:
For the mock controlplane, the defaulting was copy/pasted over from controller-runtime (I assume in some earlier state). As of https://github.com/kubernetes-sigs/controller-runtime/pull/1541/files, their defaulting got revamped, and thus we can fall back to their defaulting. Only for advanced users, we can allow to override this, but should overhaul this config in the future as well, as the property used to override is deprecated.
Fixes #