-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create namespace when running TestSuite #518
Conversation
e97f0de
to
ff6bc51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
I think this looks good apart from the hiding of error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few more nitpicks and this will be good to merge.
Signed-off-by: chenmj11 <chenmj11@lenovo.com>
Looking closer at this, the However I'm going to merge this now since it's already an improvement in the common single-cluster case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @chenmj11 !
What this PR does / why we need it:
The tests in a TestSuite fail, because the specified namespace does not exist.
kuttl-test.yaml
error logs
*Automatically closes linked issue when PR is merged.
Fixes 512