Make it possible to build with Go 1.23. #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
force-pushed
the
go-1-23-fix
branch
2 times, most recently
from
7affbc9
to
3bca337
Compare
porridge
changed the title
porridge
changed the title
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
logan-bobo
pushed a commit
to logan-bobo/kuttl
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Marcin Owsiany <porridge@redhat.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Paraphrasing the function doc:
And so it did. This PR mimics what was done in hofstadter-io/hof#392
Fixes #546
This seems to work with both of: