Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request #23

Open
tlewis99 opened this issue Aug 31, 2022 · 15 comments
Open

Feature Request #23

tlewis99 opened this issue Aug 31, 2022 · 15 comments

Comments

@tlewis99
Copy link

Is is possible to include in the backup and restore settings:
I/O / Analog tanks settings
then any customizations about Analog tanks made from the Device menu?

Let me know your thoughts.

Thanks,

Tim

@kwindrem
Copy link
Owner

I think this might be possible but each of the GX device platforms will have different parameters. By inspection, Cerbo has .../adc_builtin0/1/... .../adc_builtin0/4/... for tanks. I'm not sure what other platforms would have. I would need a complete list of dbus Settings parameters to include them all. Analog hats on the Raspberry PI would probably also have dbus parameters different from other platforms and may in fact change based on the analog interface.

Then there are separate setting parameters for the GX Tank. I would not be able to include these in the backup and restore because the dbus path includes the GX Tank's serial number which is not consistent between systems.

Unfortunately other external tank sensors utilize the external device's name (or other field) instead of having something in dbus Settings. So these would also not be included.

So if I did this, it would support ONLY Cerbo built-in tanks.

@tlewis99
Copy link
Author

tlewis99 commented Aug 31, 2022 via email

@kwindrem
Copy link
Owner

I have added Cerbo tanks (and temps) -- including alarms to backup and restore. It's currently on the beta branch so change the SetupHelper branch in PackageManager to get that version for testing.

You can also download from GitHub and install manually if you prefer. Make sure you select the beta branch before downloading!

I'll release as soon as you report back and I've fixed any bugs.

@tlewis99
Copy link
Author

tlewis99 commented Aug 31, 2022 via email

@tlewis99
Copy link
Author

tlewis99 commented Sep 1, 2022 via email

@tlewis99
Copy link
Author

tlewis99 commented Sep 1, 2022

So disregard the previous email. I setup another test and this time I rebooted after completing the restore and everything is perfect.

@kwindrem
Copy link
Owner

kwindrem commented Sep 1, 2022

I did some tests with dbus-spy and unless the standard is set to custom, changes to the sensor empty/full values are rejected. In fact, setting to US or European sets the empty/full values to defaults for those standards !!!

I looked at my settingsList and the standard is set AFTER the values. I reordered things and ran a test and the custom empty/full values seem to be restored properly.

v4.23~2 is up on GitHub now. Give it a shot.

@tlewis99
Copy link
Author

tlewis99 commented Sep 1, 2022 via email

@kwindrem
Copy link
Owner

kwindrem commented Sep 1, 2022

I tried this on my Cerbo and the tank shows in the GuiMods enhanced overviews without a reboot. And as you say, it is showing up in the device list. I also discovered what you did -- that the tank input switch shows off in the Analog inputs menu. I changed the Function dbus Setting for that input and the switch setting did not change. I also found I could no longer change the switch in the menu.

I restarted the GUI (kill all gui) and the tank then shows as on.

It appears that menu is not refreshing when parameters change from something outside that menu. I don't fully what is going on in that menu or how to fix it.

@tlewis99
Copy link
Author

tlewis99 commented Sep 1, 2022 via email

@kwindrem
Copy link
Owner

kwindrem commented Sep 1, 2022

Agreed on the tank on/off issue. It turns out if you change ANY switch setting in this menu, it refreshes the other switches also.

If you have more testing to do, I'll hold off releasing, otherwise, I'm ready on my end.

@tlewis99
Copy link
Author

tlewis99 commented Sep 1, 2022 via email

@tlewis99
Copy link
Author

tlewis99 commented Sep 2, 2022 via email

@kwindrem
Copy link
Owner

kwindrem commented Oct 11, 2022 via email

@mjelkins
Copy link

An idea for the Mopeka devices, so in my Caravan I have a Mopeka LPG device. It is working fine. I've also got a back order for the Water Tank Monitors (for my fresh water). It would be great to calculate (guesstimate) the lifespan of these tanks as to when they will get to empty... rather than get a cold shower, or simply no water. Resolution to an hour based on the last day or two would be perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants