Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds base docker setup for local mopidy #102

Merged
merged 5 commits into from
Nov 29, 2019
Merged

Adds base docker setup for local mopidy #102

merged 5 commits into from
Nov 29, 2019

Conversation

atothewest
Copy link
Contributor

@atothewest atothewest commented Nov 29, 2019 •
edited
Loading

First pass at satisfying issue #101

If someone other than me could also pull this down to validate that it works correctly that would be great. Don't remove the "Do not merge" label until at least one other person has checked.

TODO:

  • Remove mopidy dependency in docker-compose - dockerised mopidy should be optional at this point.
  • Add documentation around process
  • Secondary confirmation that. It. Works.

@atothewest atothewest self-assigned this Nov 29, 2019
whomwah
whomwah approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@whomwah whomwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Andy. I'll try running it locally too. I wonder if it's worth updating the rest of the README to point to the make commands too rather than using ./script... ?

mopidy/Dockerfile Show resolved Hide resolved
mopidy/Dockerfile Show resolved Hide resolved
mopidy/config/mopidy.conf Show resolved Hide resolved
@atothewest
removes commented mopidy conf lines
78c0176 
- switches to buster debian base image
- updates readme builds instructions to use make
- adds Werner Beroux credit for Mopidy Dockerfile
@kyan kyan deleted a comment from atothewest Nov 29, 2019
tomajwinter
tomajwinter approved these changes Nov 29, 2019
View reviewed changes
Copy link

@tomajwinter tomajwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍 - running this locally at the moment.

@atothewest atothewest merged commit 6e19f12 into master Nov 29, 2019
@atothewest atothewest deleted the docker_mopidy branch November 29, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whomwah whomwah whomwah approved these changes

@tomajwinter tomajwinter tomajwinter approved these changes

@kyanmichael kyanmichael Awaiting requested review from kyanmichael

Assignees

@atothewest atothewest

Labels
enhancement In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atothewest @whomwah @tomajwinter