Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPMs #85

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Update NPMs #85

merged 4 commits into from
Nov 19, 2019

Conversation

whomwah
Copy link
Member

@whomwah whomwah commented Nov 19, 2019

Trying to keep ontop of this:

  • Update NPMs in front and backend npm update
  • Fix 1 spec that broke after upgrade
  • Remove component that is not used.

The upgrade introduces a warning:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

Which is caused by semantic-ui-react. I guess it will go away when the fix it or we use another ui lib.

@whomwah whomwah self-assigned this Nov 19, 2019
@tomajwinter
Copy link

👍

(Looks like semantic UI have a long running issue around that lifecycle deprecation, but are addressing it Semantic-Org/Semantic-UI-React#2732)

@whomwah whomwah merged commit 7ea1d79 into master Nov 19, 2019
@whomwah whomwah deleted the update_npms branch November 19, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants