Unify event handling between client, api and mopidy #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whomwah
changed the title
dquilter
approved these changes
Nov 25, 2019
tomajwinter
approved these changes
Nov 25, 2019
tomajwinter
reviewed
Nov 25, 2019
kyanmichael
reviewed
Nov 25, 2019
kyanmichael
reviewed
Nov 25, 2019
kyanmichael
reviewed
Nov 26, 2019
frontend/src/containers/dashboard/__snapshots__/index.spec.js.snap
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event handling between the client the websocket server and mopidy has always been a bit of a work in progress. Mainly because it's a difficult one to grok. Now we've had the JB running for a few days solid with real interaction it's been easier to identify where the problems are. This PR attempts to solve them.
There is now a different event sent to the client depending on whether a connection has been made to the API or Mopidy.
The PR also brings back
pause. There is an ongoing problem with Mopidy where if left paused for a long period of time, it consumes all the CPU and crashes the Pi. This appears to be related to the fact that when youpausemopidy, it keeps its connection to the Pi sounds card whereasstopreleases the connection. This is reflected in the functionality.pausecan be resumed from where youpaused.stopon the other had stops the track and takes it back to the beginning. Because we now auto switch off the jukebox at the end of the day and don't pause the JB for long periods of time I have now added bothpauseandstop.Address issue #90