Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for table.concat, table.insert, table.remove, tonumber, string.sub #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

svermeulen
Copy link

Also changed print() to use space instead of tab between arguments since this is how the official lua implementation seems to work.

Should also note that I'm new to Rust so please let me know if I'm not following best practices

@kyren
Copy link
Owner

kyren commented Nov 8, 2023

Thank you for the PR!

I haven't looked in detail yet at all, I wanted to reply to this comment first.

Also changed print() to use space instead of tab between arguments since this is how the official lua implementation seems to work.

Lua 5.3 and Lua 5.4 both print tabs? That's specifically why I implemented it that way. What version of Lua are you comparing with?

@kyren
Copy link
Owner

kyren commented Nov 8, 2023

I haven't finished the review but I hit a snag.. I need to research precisely what table.insert and table.remove even do in PUC-Rio Lua first to even know what has to be done.

@kyren
Copy link
Owner

kyren commented Nov 8, 2023

I understand contributing to this project is no fun lol. That's actually pretty much the reason I stopped explicitly asking for contributions, there are too many things that are not so much work that has to be done but questions that need to be answered, lots of things are like this and just end up being a quagmire for a new contributor.

What would be great would be to make an official chat server, so that people who wanted to contribute could join and talk about this stuff synchronously, otherwise the back and forth over github PRs will be agonizingly slow.

If I made a discord server, would you be willing to talk there? Would matrix be better? I have a few other people who should probably join, but the last thing I really want to do is manage a discord server so I'm not sure what the best course of action is.

@kyren
Copy link
Owner

kyren commented Nov 8, 2023

I added a chat link to the README, a new #piccolo channel on the Spicy Lobster gamedev server, which I'll try to have all piccolo related discussions in for the foreseeable future. (Older discussions took place in #code)

@svermeulen
Copy link
Author

Lua 5.3 and Lua 5.4 both print tabs? That's specifically why I implemented it that way. What version of Lua are you comparing with?

Ohh ok that makes sense. I was comparing it to Lua 5.1. I've reverted that change now.

I've joined the discord so will coordinate any work there going forward! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants