Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Skip duplicates not working on some filenames #156

Closed
divyam234 opened this issue Apr 9, 2021 · 4 comments
Closed

[BUG] Skip duplicates not working on some filenames #156

divyam234 opened this issue Apr 9, 2021 · 4 comments
Labels
bug

Comments

@divyam234
Copy link

divyam234 commented Apr 9, 2021 •
edited
Loading

I have some files named like 10-abc -abc xyz't abx which are not counted as duplicates when I run the upload process second time I am assuming some special chars in file names are causing this in this case it is caused to do comma but If I remove this comma then it is counted as duplicate.
@Akianonymus
Copy link
Collaborator

Provide the exact filenames.

@divyam234
Copy link
Author

divyam234 commented May 11, 2021 •
edited
Loading

@Akianonymus
gupload "10-abctest's.ipynb" -d

Running this is creating two files with same name here extension can be any extension

@Akianonymus
Copy link
Collaborator

@divyam234 Yeah, can confirm. Will push the fixes soon.

@Akianonymus Akianonymus changed the title Redownloading duplicates [BUG] Skip duplicates not working on some filenames May 16, 2021
Akianonymus added a commit to Akianonymus/google-drive-upload that referenced this issue May 16, 2021
@Akianonymus
[BUGFIX]: Handle special chars in filenames | Resolve labbots#156
ac290ca 
try to follow https://tools.ietf.org/html/rfc7159#section-7

use _json_escape function to handle it

also use parsed var to properly handle pretty printing
@Akianonymus
Copy link
Collaborator

@divyam234 Update to the latest version, fixes have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akianonymus @divyam234