Fix #113 | Handle more api errors | More robust credentials handling | Misc #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akianonymus
force-pushed
the
master
branch
8 times, most recently
from
930f726
to
39f8cfd
Compare
labbots
previously approved these changes
Oct 20, 2020
Akianonymus
force-pushed
the
master
branch
10 times, most recently
from
9c7f08f
to
b1ae0dc
Compare
|
@labbots Approve |
Akianonymus
force-pushed
the
master
branch
2 times, most recently
from
4a53368
to
560ee15
Compare
labbots
previously approved these changes
Oct 23, 2020
There was a problem hiding this comment.
@Akianonymus Do not add more commits to this PR. If you make any further changes then create a new PR.
Thank you
|
Yeah, i should actually seperate these into different prs. |
labbots
previously approved these changes
Oct 25, 2020
Akianonymus
force-pushed
the
master
branch
2 times, most recently
from
b16fe46
to
4ec7829
Compare
labbots
previously approved these changes
Oct 27, 2020
Akianonymus
force-pushed
the
master
branch
5 times, most recently
from
7ee53fe
to
a23fd6d
Compare
launch a background service to check access token and update it checks ACCESS_TOKEN_EXPIRY, try to update before 5 mins of expiry, a fresh token gets 60 mins ( 3600 seconds ) process will be killed when script exits dont update config in bg service, update at script exit create a temp file where updated access token will be stored by the bg service every function that uses access token will source it on every call make a new function named _api_request for all oauth network calls decrease a network request ( to fetch expiry of access token, just calculate it locally using remaining time given in json as expires_in ) google-oauth2.[bash|sh]: Apply new changes
|
@labbots approve, this can be merged now. |
Akianonymus
force-pushed
the
master
branch
2 times, most recently
from
61486ec
to
9b6b848
Compare
Akianonymus
changed the title
Handle edgecase when curl http code is 000 in case of resumeable uploads proper handle other problems like rate limits, or any other api side problem follow # rclone/rclone#3857 (comment) never retry if upload limit is reached ( upload qouta )
use regex pattern to verify ( to some extent )
|
@Akianonymus I keep reviewing this massive PR over and over again. Kindly merge this PR and then create a new PR for any additional changes. |
labbots
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.