You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes public the arbitrary module, with the proptest::arbitrary::Arbitrary implementation for Felt252 along with some helper functions, via the arbitrary feature.
The arbitrary feature enables the arbitrary dependency, while this one enables the proptest dependency. Those are two different things. Albeit they both have an Arbitrary trait, they have different signatures (it's really confusing).
Do you think that combining the two features would be ok?
Oh. Is this about the proptest::Arbitrary and the quickcheck::Arbitrary? I would suggest instead those features are either collapsed into one as you suggest or be something like pt_arbitrary and qc_arbitrary (maybe not abbreviated, however you prefer).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes public the
arbitrary
module, with theproptest::arbitrary::Arbitrary
implementation forFelt252
along with some helper functions, via the arbitrary feature.Checklist