Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signature error message #1361

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix signature error message #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c52610
Fix signature error
FabijanC Aug 4, 2023
511b26e
Update CHANGELOG.md
FabijanC Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: correctly display invalid signature error message [#1361](https://github.com/lambdaclass/cairo-vm/pull/1361)

#### [0.8.5] - 2023-7-31

* fix: `Program` comparison depending on `hints_ranges` ordering [#1351](https://github.com/lambdaclass/cairo-rs/pull/1351)
Expand Down
2 changes: 1 addition & 1 deletion vm/src/vm/runners/builtin_runner/signature.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
match verify(&public_key, &message, &r, &s) {
Ok(true) => Ok(vec![]),
_ => Err(MemoryError::InvalidSignature(Box::new((
signature.to_string(),
format!("({}, {})", signature.r, signature.s),

Check warning on line 140 in vm/src/vm/runners/builtin_runner/signature.rs

View check run for this annotation

Codecov / codecov/patch

vm/src/vm/runners/builtin_runner/signature.rs#L140 

Added line #L140 was not covered by tests
pubkey.into_owned(),
msg.into_owned(),
)))),
Expand Down
Loading