-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error in hint UINT256_MUL_DIV_MOD
when divides by zero
#1367
Conversation
UINT256_MUL_DIV_MOD
when divides by zero
Codecov Report
@@ Coverage Diff @@
## main #1367 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 93 93
Lines 37854 37857 +3
=======================================
+ Hits 36904 36907 +3
Misses 950 950
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need tests for the failing cases as reported by Codecov.
Nice catch @Oppen!! I remove both of that checks because they were unreacheble 2766a75 Gets the values from a constant defined in the https://github.com/starkware-libs/cairo-lang/blob/0614f265421735bbb567d9b5897791a51b3705de/src/starkware/cairo/common/math.cairo#L156 library |
* fix bug * Add test * Add some checks to div_mod_floors of BigUints * Update Changelog * Remove unnecesarry zero check * Remove unnecesarry zero check * Remove unnecesary import
* Handle error in hint `UINT256_MUL_DIV_MOD` when divides by zero (#1367) * fix bug * Add test * Add some checks to div_mod_floors of BigUints * Update Changelog * Remove unnecesarry zero check * Remove unnecesarry zero check * Remove unnecesary import * release 0.6.3 * Fix CI * Revert "Fix CI" This reverts commit 2184add. * Fix CI * pin nextest version in GH workflow (#1359) * remove codecov * Run benchmarks serially in the CI (#1280) The benchmarks consume a lot of memory. Since we disabled swap memory usage, the bench runs fail sporadically because of OOM errors. This makes them run with 1 process instead of 2 in parallel. * Revert "remove codecov" This reverts commit f10a7cf. * Revert "Revert "remove codecov"" This reverts commit fde126e. --------- Co-authored-by: Tomás <47506558+MegaRedHand@users.noreply.github.com>
Handle error in hint
UINT256_MUL_DIV_MOD
when divides by zeroDescription
UINT256_MUL_DIV_MOD
when divides by zerodiv_mod_floor
withBigUints
Checklist