Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix div_mod #1383

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Fix div_mod #1383

merged 6 commits into from
Aug 17, 2023

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Aug 17, 2023

Solves #1381

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1383 (6920ec1) into main (030b7eb) will increase coverage by 0.00%.
The diff coverage is 99.13%.

@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          93       93           
  Lines       37857    37924   +67     
=======================================
+ Hits        36907    36973   +66     
- Misses        950      951    +1     
Files Changed Coverage Δ
...rc/hint_processor/builtin_hint_processor/vrf/fq.rs 96.66% <94.44%> (-0.87%) ⬇️
...rc/hint_processor/builtin_hint_processor/bigint.rs 97.63% <100.00%> (-0.02%) ⬇️
...int_processor/builtin_hint_processor/ec_recover.rs 100.00% <100.00%> (ø)
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.54% <100.00%> (ø)
...ocessor/builtin_hint_processor/secp/field_utils.rs 99.70% <100.00%> (ø)
...processor/builtin_hint_processor/secp/signature.rs 99.04% <100.00%> (-0.01%) ⬇️
...or/builtin_hint_processor/vrf/inv_mod_p_uint512.rs 100.00% <100.00%> (ø)
.../hint_processor/builtin_hint_processor/vrf/pack.rs 100.00% <100.00%> (ø)
vm/src/math_utils/mod.rs 99.44% <100.00%> (+0.05%) ⬆️
vm/src/vm/runners/builtin_runner/ec_op.rs 98.69% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta marked this pull request as ready for review August 17, 2023 16:18
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.939 ± 0.056 4.845 5.004 1.00
head big_factorial 4.968 ± 0.053 4.879 5.074 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.204 ± 0.049 4.119 4.268 1.00
head big_fibonacci 4.290 ± 0.044 4.208 4.357 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.724 ± 0.124 11.424 11.865 1.00
head blake2s_integration_benchmark 11.867 ± 0.195 11.621 12.221 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.279 ± 0.084 4.190 4.506 1.00
head compare_arrays_200000 4.318 ± 0.049 4.247 4.420 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.792 ± 0.039 2.721 2.853 1.00
head dict_integration_benchmark 2.844 ± 0.045 2.775 2.916 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.974 ± 0.044 1.908 2.061 1.02 ± 0.03
head field_arithmetic_get_square_benchmark 1.935 ± 0.038 1.881 1.991 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.503 ± 0.078 11.388 11.640 1.00
head integration_builtins 11.634 ± 0.093 11.501 11.812 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.986 ± 0.126 11.766 12.192 1.00
head keccak_integration_benchmark 12.123 ± 0.266 11.895 12.837 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.289 ± 0.062 4.232 4.415 1.00 ± 0.02
head linear_search 4.271 ± 0.049 4.199 4.357 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.094 ± 0.038 3.049 3.167 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 3.069 ± 0.036 3.022 3.122 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.731 ± 0.028 2.702 2.781 1.00
head math_integration_benchmark 2.749 ± 0.052 2.673 2.850 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.455 ± 0.059 2.364 2.541 1.00
head memory_integration_benchmark 2.489 ± 0.039 2.422 2.539 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.626 ± 0.036 2.573 2.671 1.00
head operations_with_data_structures_benchmarks 2.656 ± 0.046 2.602 2.730 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.013 ± 0.021 0.993 1.045 1.01 ± 0.03
head pedersen 0.998 ± 0.025 0.965 1.036 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.762 ± 0.040 1.710 1.846 1.01 ± 0.03
head poseidon_integration_benchmark 1.751 ± 0.021 1.711 1.775 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.277 ± 0.053 3.218 3.408 1.00
head secp_integration_benchmark 3.470 ± 0.043 3.392 3.553 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.016 ± 0.023 1.963 2.047 1.04 ± 0.03
head set_integration_benchmark 1.945 ± 0.050 1.895 2.063 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.327 ± 0.106 7.175 7.563 1.00
head uint256_integration_benchmark 7.385 ± 0.105 7.257 7.586 1.01 ± 0.02

@pefontana pefontana added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 4d36f96 Aug 17, 2023
39 checks passed
@pefontana pefontana deleted the fix-div-mod branch August 17, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants