Use starknet-types-core Felt
#1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
previously approved these changes
Dec 21, 2023
fmoletta
reviewed
Dec 21, 2023
.github/workflows/rust.yml
Outdated
Comment on lines
261
to
266
| cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}-${{ matrix.special_features }}.info \ | ||
| cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info \ | ||
| --partition count:${PARTITION}/4 \ | ||
| --workspace --features "cairo-1-hints, test_utils, ${{ matrix.special_features }}" | ||
| --workspace --features "cairo-1-hints, test_utils" | ||
| ;; | ||
| 'test-no_std') | ||
| cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}-${{ matrix.special_features }}.info \ | ||
| cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info \ | ||
| --partition count:${PARTITION}/4 \ | ||
| --workspace --no-default-features --features "${{ matrix.special_features }}" | ||
| --workspace --no-default-features | ||
| ;; | ||
| 'test-wasm') | ||
| # NOTE: release mode is needed to avoid "too many locals" error | ||
| wasm-pack test --release --node vm --no-default-features --features "${{ matrix.special_features }}" | ||
| wasm-pack test --release --node vm --no-default-features |
There was a problem hiding this comment.
We should restore this, as we added the "extensive-hints" feature recently and it should be tested
fmoletta
reviewed
Dec 21, 2023
Comment on lines
+54
to
+82
| pub fn felt_to_biguint(felt: crate::Felt252) -> BigUint { | ||
| let big_digits = felt | ||
| .to_le_digits() | ||
| .into_iter() | ||
| .flat_map(|limb| [limb as u32, (limb >> 32) as u32]) | ||
| .collect(); | ||
| BigUint::new(big_digits) | ||
| } | ||
|
|
||
| pub fn felt_to_bigint(felt: crate::Felt252) -> BigInt { | ||
| felt_to_biguint(felt).to_bigint().unwrap() | ||
| } | ||
|
|
||
| pub fn biguint_to_felt(biguint: &BigUint) -> Result<crate::Felt252, MathError> { | ||
| // TODO This funtions should return a Felt252 instead of a Result | ||
| Ok(crate::Felt252::from_bytes_le_slice(&biguint.to_bytes_le())) | ||
| } | ||
|
|
||
| pub fn bigint_to_felt(bigint: &BigInt) -> Result<crate::Felt252, MathError> { | ||
| let (sign, bytes) = bigint | ||
| .mod_floor(&CAIRO_PRIME.to_bigint().unwrap()) | ||
| .to_bytes_le(); | ||
| let felt = crate::Felt252::from_bytes_le_slice(&bytes); | ||
| if sign == Sign::Minus { | ||
| Ok(felt.neg()) | ||
| } else { | ||
| Ok(felt) | ||
| } | ||
| } |
There was a problem hiding this comment.
The new version of starknet-core-types implements conversions between Felt & biguint/bigint so we can use those and remove these functions
There was a problem hiding this comment.
I suggest we leave them and refactor later. This PR has been lingering for a while and this limbo is getting in the way of some downstream devs too.
Oppen
previously approved these changes
Dec 21, 2023
fmoletta
previously approved these changes
Dec 21, 2023
Oppen
previously approved these changes
Dec 21, 2023
fmoletta
approved these changes
Dec 21, 2023
Oppen
approved these changes
Dec 21, 2023
|
🔥 |
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
cairo-feltcrate withstarknet-types-coreChange the
Felt252struct implemented in thecairo-feltcrate with one fromstarknet-types-core