Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant memory_hole checks from cairo_run_tests module #1586

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

fmoletta
Copy link
Member

Closes #1584
Preferrably merge after #1578, as checks are replaced by cairo pie output comparison

@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Jan 18, 2024
@fmoletta fmoletta changed the title Remove memory_hole checks from cairo_run_tests.rs tests Remove redundant memory_hole checks from cairo_run_tests.rs tests Jan 18, 2024
@fmoletta fmoletta changed the title Remove redundant memory_hole checks from cairo_run_tests.rs tests Remove redundant memory_hole checks from cairo_run_tests module Jan 18, 2024
@fmoletta fmoletta marked this pull request as ready for review January 18, 2024 20:53
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e806ee3) 97.17% compared to head (9c7bfa8) 97.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          91       91           
  Lines       37175    37175           
=======================================
  Hits        36124    36124           
  Misses       1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 18, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.246 ± 0.013 2.230 2.267 1.00
head big_factorial 2.250 ± 0.016 2.233 2.293 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.231 ± 0.018 2.214 2.266 1.00 ± 0.01
head big_fibonacci 2.228 ± 0.014 2.210 2.255 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.186 ± 0.081 8.102 8.298 1.01 ± 0.01
head blake2s_integration_benchmark 8.134 ± 0.060 8.095 8.292 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.291 ± 0.022 2.266 2.337 1.00 ± 0.01
head compare_arrays_200000 2.285 ± 0.016 2.263 2.315 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.450 ± 0.017 1.437 1.493 1.00 ± 0.01
head dict_integration_benchmark 1.445 ± 0.007 1.437 1.463 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.297 ± 0.014 1.285 1.322 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.296 ± 0.010 1.283 1.315 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.258 ± 0.090 8.153 8.346 1.00
head integration_builtins 8.259 ± 0.112 8.137 8.435 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.466 ± 0.086 8.373 8.609 1.01 ± 0.01
head keccak_integration_benchmark 8.396 ± 0.026 8.378 8.440 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.321 ± 0.020 2.288 2.352 1.00 ± 0.01
head linear_search 2.316 ± 0.021 2.300 2.366 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.593 ± 0.013 1.583 1.626 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.592 ± 0.015 1.578 1.629 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.454 ± 0.005 1.447 1.462 1.01 ± 0.01
head math_integration_benchmark 1.446 ± 0.007 1.438 1.455 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.263 ± 0.018 1.248 1.298 1.01 ± 0.02
head memory_integration_benchmark 1.255 ± 0.009 1.247 1.271 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.627 ± 0.005 1.622 1.639 1.00
head operations_with_data_structures_benchmarks 1.628 ± 0.012 1.615 1.653 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 605.7 ± 7.1 600.9 625.0 1.01 ± 0.01
head pedersen 602.5 ± 1.4 600.5 605.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.058 ± 0.004 1.052 1.064 1.00
head poseidon_integration_benchmark 1.062 ± 0.013 1.054 1.100 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.925 ± 0.007 1.918 1.944 1.00 ± 0.00
head secp_integration_benchmark 1.919 ± 0.006 1.913 1.929 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 770.7 ± 2.2 768.1 774.6 1.00
head set_integration_benchmark 773.0 ± 2.3 769.6 776.4 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.538 ± 0.019 4.523 4.589 1.00
head uint256_integration_benchmark 4.556 ± 0.045 4.514 4.638 1.00 ± 0.01

@Oppen Oppen added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit b910403 Jan 22, 2024
50 checks passed
@Oppen Oppen deleted the remove-memory-hole-count-from-test branch January 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Remove memory_holes checks for tests in cairo_run_tests.rs
3 participants