Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cairo-lang version to 2.5.3 #1596

Merged
merged 29 commits into from
Feb 10, 2024
Merged

Update cairo-lang version to 2.5.3 #1596

merged 29 commits into from
Feb 10, 2024

Conversation

pefontana
Copy link
Member

@pefontana pefontana commented Feb 1, 2024

Bump cairo-lang- dependencies to 2.5.3

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Feb 1, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.280 ± 0.023 2.251 2.330 1.00
head big_factorial 2.292 ± 0.009 2.276 2.306 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.239 ± 0.007 2.228 2.251 1.00
head big_fibonacci 2.284 ± 0.034 2.249 2.370 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.440 ± 0.027 8.412 8.497 1.00
head blake2s_integration_benchmark 8.492 ± 0.051 8.447 8.619 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.339 ± 0.018 2.316 2.376 1.00
head compare_arrays_200000 2.340 ± 0.019 2.318 2.373 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.454 ± 0.010 1.444 1.476 1.00
head dict_integration_benchmark 1.456 ± 0.005 1.447 1.463 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.311 ± 0.012 1.301 1.344 1.00
head field_arithmetic_get_square_benchmark 1.396 ± 0.030 1.376 1.478 1.07 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.494 ± 0.072 8.424 8.677 1.00
head integration_builtins 8.505 ± 0.048 8.461 8.591 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.712 ± 0.033 8.666 8.756 1.00
head keccak_integration_benchmark 8.872 ± 0.313 8.691 9.732 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.362 ± 0.033 2.338 2.451 1.01 ± 0.01
head linear_search 2.345 ± 0.010 2.333 2.362 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.583 ± 0.014 1.570 1.616 1.00
head math_cmp_and_pow_integration_benchmark 1.806 ± 0.006 1.793 1.813 1.14 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.444 ± 0.006 1.437 1.453 1.00
head math_integration_benchmark 1.619 ± 0.027 1.595 1.667 1.12 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.269 ± 0.006 1.263 1.279 1.00
head memory_integration_benchmark 1.273 ± 0.008 1.265 1.289 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.610 ± 0.004 1.604 1.616 1.00
head operations_with_data_structures_benchmarks 1.907 ± 0.015 1.894 1.950 1.18 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 592.2 ± 6.1 587.2 608.0 1.00
head pedersen 593.7 ± 4.4 589.5 605.3 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 975.7 ± 9.5 963.5 999.7 1.00
head poseidon_integration_benchmark 981.8 ± 5.8 976.4 995.8 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.880 ± 0.023 1.868 1.945 1.00
head secp_integration_benchmark 1.941 ± 0.010 1.929 1.958 1.03 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 726.3 ± 4.3 721.6 733.7 1.00
head set_integration_benchmark 727.5 ± 4.8 723.3 739.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.662 ± 0.018 4.639 4.698 1.00
head uint256_integration_benchmark 4.676 ± 0.024 4.633 4.698 1.00 ± 0.01

@pefontana pefontana linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ddc90) 97.72% compared to head (e6bd158) 97.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          91       91           
  Lines       37278    37278           
=======================================
  Hits        36429    36429           
  Misses        849      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pefontana pefontana marked this pull request as ready for review February 9, 2024 21:18
Copy link
Member

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pefontana pefontana added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@pefontana pefontana added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@juanbono juanbono added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@pefontana pefontana added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@pefontana pefontana added this pull request to the merge queue Feb 10, 2024
Merged via the queue into main with commit 1f98fef Feb 10, 2024
50 checks passed
@pefontana pefontana deleted the cairo-lang-2.5.3 branch February 10, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump cairo deps to 2.5.3
3 participants