Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use return type info from sierra when serializing return values in cairo1-run crate #1665

Merged
merged 27 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6f3f4fb
Start implementing new serialize_output
fmoletta Mar 14, 2024
e5dc7b6
Handle enums
fmoletta Mar 14, 2024
05145c2
Add extra handling for boolean enums
fmoletta Mar 14, 2024
e687e9f
Use new serialization in main loop
fmoletta Mar 14, 2024
f2cef89
Handle panic wrapper
fmoletta Mar 14, 2024
af63def
Fix panic handling
fmoletta Mar 14, 2024
784400b
Fix variant idx calc
fmoletta Mar 14, 2024
f07fe79
Add test for dict with struct
fmoletta Mar 14, 2024
5ed98f4
Add Array & Snapshot
fmoletta Mar 14, 2024
1425b24
Fix
fmoletta Mar 14, 2024
3d4a6e9
Handle box + fix spellings + update tests
fmoletta Mar 14, 2024
2cbc4e6
Update test value
fmoletta Mar 14, 2024
b26476c
Add signed felt
fmoletta Mar 14, 2024
4ea2110
Add test for squashed dict
fmoletta Mar 14, 2024
621ca97
Handle Nullable being Null
fmoletta Mar 14, 2024
f6a60bf
Complete unhandled barnches
fmoletta Mar 14, 2024
f11fd56
Clippy
fmoletta Mar 15, 2024
b522fac
Remove old impl of serialize_output
fmoletta Mar 15, 2024
34d3ba5
Add Changelog entry
fmoletta Mar 15, 2024
89ad3a3
Fix comments
fmoletta Mar 15, 2024
710b6a7
Remove empty case
fmoletta Mar 15, 2024
cd28e6d
Fox typo
fmoletta Mar 15, 2024
f3c1478
Handle multiple array formats when serializing
fmoletta Mar 18, 2024
8211b04
Add test
fmoletta Mar 18, 2024
69e244e
Fix test value
fmoletta Mar 18, 2024
7979f5b
Merge branch 'main' into use-sierra-info-to-process-return-values
pefontana Mar 18, 2024
014b4af
Merge branch 'main' into use-sierra-info-to-process-return-values
fmoletta Mar 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

#### Upcoming Changes

* feat(BREAKING): Use return type info from sierra when serializing return values in cairo1-run crate [#1665](https://github.com/lambdaclass/cairo-vm/pull/1665)
* Removed public function `serialize_output`.
* Add field `serialize_output` to `Cairo1RunConfig`.
* Function `cairo_run_program` now returns an extra `Option<String>` value with the serialized output if `serialize_output` is enabled in the config.
* Output serialization improved as it now uses the sierra program data to identify return value's types.

* feat: Create hyper_threading crate to benchmark the `cairo-vm` in a hyper-threaded environment [#1679](https://github.com/lambdaclass/cairo-vm/pull/1679)

* feat: add a `--tracer` option which hosts a web server that shows the line by line execution of cairo code along with memory registers [#1265](https://github.com/lambdaclass/cairo-vm/pull/1265)
Expand Down
1 change: 1 addition & 0 deletions cairo1-run/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ bincode.workspace = true
assert_matches = "1.5.0"
rstest = "0.17.0"
mimalloc = { version = "0.1.37", default-features = false, optional = true }
num-traits = { version = "0.2", default-features = false }

[features]
default = ["with_mimalloc"]
Expand Down
Loading
Loading