Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod builtin #1673

Merged
merged 138 commits into from
Apr 9, 2024
Merged

Add mod builtin #1673

merged 138 commits into from
Apr 9, 2024

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Mar 18, 2024

Implements ModBuiltinRunner
Adds add_mod & mul_mod to layouts all_cairo & dynamic under mod_builtin feature
Removes unused and duplicated code from builtin_runner module

Copy link

github-actions bot commented Mar 18, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.291 ± 0.035 2.251 2.345 1.00
head big_factorial 2.298 ± 0.027 2.268 2.334 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.241 ± 0.021 2.223 2.282 1.00
head big_fibonacci 2.267 ± 0.087 2.204 2.496 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.562 ± 0.156 8.380 8.877 1.01 ± 0.02
head blake2s_integration_benchmark 8.497 ± 0.033 8.463 8.577 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.352 ± 0.026 2.320 2.412 1.01 ± 0.02
head compare_arrays_200000 2.336 ± 0.027 2.309 2.391 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.416 ± 0.009 1.406 1.435 1.00
head dict_integration_benchmark 1.443 ± 0.025 1.424 1.490 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.309 ± 0.010 1.294 1.331 1.00
head field_arithmetic_get_square_benchmark 1.319 ± 0.012 1.303 1.333 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.569 ± 0.089 8.390 8.638 1.00
head integration_builtins 8.606 ± 0.122 8.460 8.749 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.003 ± 0.385 8.664 9.642 1.01 ± 0.05
head keccak_integration_benchmark 8.876 ± 0.242 8.737 9.505 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.352 ± 0.017 2.331 2.374 1.01 ± 0.01
head linear_search 2.328 ± 0.016 2.314 2.367 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.586 ± 0.016 1.561 1.615 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.575 ± 0.017 1.550 1.604 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.443 ± 0.023 1.411 1.482 1.01 ± 0.02
head math_integration_benchmark 1.432 ± 0.012 1.418 1.451 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.273 ± 0.019 1.248 1.300 1.01 ± 0.02
head memory_integration_benchmark 1.265 ± 0.015 1.256 1.308 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.623 ± 0.025 1.603 1.683 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.609 ± 0.016 1.598 1.651 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 592.3 ± 3.7 589.1 602.0 1.00
head pedersen 596.8 ± 8.9 590.2 619.4 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 987.5 ± 10.8 978.6 1015.6 1.01 ± 0.01
head poseidon_integration_benchmark 982.3 ± 6.5 972.2 991.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.868 ± 0.012 1.859 1.897 1.00
head secp_integration_benchmark 1.887 ± 0.019 1.865 1.928 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 716.9 ± 3.7 712.5 724.6 1.00
head set_integration_benchmark 721.0 ± 4.7 716.6 728.9 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.652 ± 0.034 4.601 4.711 1.00
head uint256_integration_benchmark 4.700 ± 0.051 4.641 4.763 1.01 ± 0.01

@fmoletta fmoletta added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 5, 2024
@juanbono juanbono added this pull request to the merge queue Apr 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 6, 2024
@juanbono juanbono added this pull request to the merge queue Apr 8, 2024
@juanbono juanbono removed this pull request from the merge queue due to a manual request Apr 8, 2024
@fmoletta fmoletta enabled auto-merge April 8, 2024 21:13
@fmoletta fmoletta added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@fmoletta fmoletta linked an issue Apr 9, 2024 that may be closed by this pull request
@fmoletta fmoletta enabled auto-merge April 9, 2024 15:24
@fmoletta fmoletta added this pull request to the merge queue Apr 9, 2024
@fmoletta fmoletta removed this pull request from the merge queue due to a manual request Apr 9, 2024
@fmoletta fmoletta added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 15f9dc0 Apr 9, 2024
69 of 70 checks passed
@fmoletta fmoletta deleted the add-mod-builtin-runner branch April 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arithmetic circuit builtin
4 participants