Ignore memory order in CairoPie validation. #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alon-Ti
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
fmoletta
reviewed
Jun 3, 2024
Alon-Ti
force-pushed
the
cairo-pie-memory-order
branch
from
26b381b
to
00fdddd
Compare
juanbono
reviewed
Jun 3, 2024
Alon-Ti
force-pushed
the
cairo-pie-memory-order
branch
from
00fdddd
to
db13127
Compare
juanbono
approved these changes
Jun 4, 2024
|
Thanks for the fix! Can you add a short line to the CHANGELOG file with the changes in this PR? |
Alon-Ti
force-pushed
the
cairo-pie-memory-order
branch
from
db13127
to
5712adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare memories as HashMaps during CairoPie validation to ignore memory order.