Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set memory_limit=-1 by default #116

Closed
Ocramius opened this issue Jul 25, 2022 · 0 comments · Fixed by #118
Closed

Set memory_limit=-1 by default #116

Ocramius opened this issue Jul 25, 2022 · 0 comments · Fixed by #118
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@Ocramius
Copy link
Member

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

Our CI runs often run infection/infection, which is memory-intensive (unavoidable).

I think that setting a memory limit is an artificial limitation that is already well enforced by the GitHub Actions infrastructure (should we hit it): we should probably have memory_limit=-1 by default.

A memory limit enforced PHP-side doesn't give us any advantage, since it's mostly detrimental in non-web contexts anyway (and should be managed by a supervisor process anyway).

Ref: laminas/automatic-releases@af78115

@Ocramius Ocramius added this to the 1.22.0 milestone Jul 25, 2022
@Ocramius Ocramius added Bug Something isn't working and removed Enhancement labels Jul 25, 2022
@Ocramius Ocramius self-assigned this Jul 25, 2022
Ocramius added a commit to Ocramius/laminas-continuous-integration-action that referenced this issue Jul 25, 2022
Ocramius added a commit that referenced this issue Jul 25, 2022
…pi-settings

Fix #116: ensure `.ini` settings are reset for both `phpdbg` and `php-cli` SAPIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
1 participant