Ensure BEFORE_SCRIPT and AFTER_SCRIPT are populated correctly

[internalsystemerror]

After discussions with @ghostwriter, and after some simple testing on this myself to confirm, this is the proposed fix to prevent the error:

/usr/local/bin/entrypoint.sh: line 147: readarray: `BEFORE_SCRIPT=xmllint --schema vendor/phpunit/phpunit/phpunit.xsd phpunit.xml.dist': not a valid identifier

Note: I'm not able to use git CLI right now, but consider this signed off.

[boesing]

As stated in slack:

I would avoid the whole file descriptor stuff.
Just change the code like this and we have dedicated commands.

declare -a BEFORE_SCRIPT=()
readarray -t BEFORE_SCRIPT < <(echo "${JOB}" | jq -rc '(.before_script // [])[]' )

declare -a AFTER_SCRIPT=()
readarray -t AFTER_SCRIPT < <(echo "${JOB}" | jq -rc '(.after_script // [])[]' )

There should be no before_script which provides multiline commands. As of now, we do only provide before_script via the matrix itself without the ability to read it from i.e. .laminas-ci.json and thus, that might already be fine.

Not sure if we need an extra safe-guard for multiline commands. Upstream projects already can provide .laminas-ci/pre-run.sh where they can have their super complex multiline whatever before_script logic.

[internalsystemerror]

Sorry for the force push, needed to signoff that earlier commit.

Thanks also to @boesing and @Xerkus for their help with this

[boesing]

LGTM

[boesing]

I'd say, 🚢