Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default --prefer-dist during composer install (#126) #127

Merged
merged 1 commit into from
Sep 5, 2022
Merged

remove default --prefer-dist during composer install (#126) #127

merged 1 commit into from
Sep 5, 2022

Conversation

basz
Copy link
Contributor

@basz basz commented Sep 5, 2022 •
edited by Ocramius
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #126

@basz
remove prefer-dist (laminas#126)
e143e14 
Signed-off-by: Bas Kamer <bas@bushbaby.nl>
@basz
Copy link
Contributor Author

basz commented Sep 5, 2022

unsure about the branch to make the PR to...

@Ocramius Ocramius added this to the 1.25.0 milestone Sep 5, 2022
@Ocramius
Copy link
Member

Ocramius commented Sep 5, 2022

Should be fine as-is 👍

@Ocramius Ocramius self-assigned this Sep 5, 2022
Ocramius
Ocramius approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius merged commit 3d402be into laminas:1.25.x Sep 5, 2022
@Ocramius Ocramius changed the title remove prefer-dist (#126) remove default --prefer-dist during composer install (#126) Sep 5, 2022
@Ocramius Ocramius mentioned this pull request Sep 5, 2022
Closed
@froschdesign
Copy link
Member

@basz

unsure about the branch to make the PR to...

See the contributing guidelines (linked here on GitHub in various places, e.g. below each comment field):

Which branch should you issue a pull request against?

  • For fixes against the stable release, issue the pull request against the release branch matching the minor release you want to fix.
  • For new features, or fixes that introduce new elements to the public API (such as new public methods or properties), issue the pull request against the default branch.

@basz basz mentioned this pull request Sep 5, 2022
Merged
basz added a commit to basz/standard-projections that referenced this pull request Sep 5, 2022
@basz
not needed anymore
02c7ef7 
laminas/laminas-continuous-integration-action#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

remove --prefer-dist from composer arguments
3 participants
@basz @Ocramius @froschdesign