Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding make to CI container as per #135 #138

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Adding make to CI container as per #135 #138

merged 1 commit into from
Nov 8, 2022

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Nov 8, 2022

The make command was missing: it is used by some pecl commands, as well as some build commands internal to php-src.

Fixes #135

@Ocramius
Adding make to CI container as per laminas#135
7010d93 
The `make` command was missing: it is used by some `pecl` commands, as well
as some build commands internal to php-src.

Fixes laminas#135
@Ocramius Ocramius added Enhancement dependencies Pull requests that update a dependency file labels Nov 8, 2022
@Ocramius Ocramius added this to the 1.29.0 milestone Nov 8, 2022
@Ocramius Ocramius mentioned this pull request Nov 8, 2022
Closed
@Ocramius Ocramius requested a review from boesing November 8, 2022 09:11
@Ocramius Ocramius self-assigned this Nov 8, 2022
@Ocramius
Copy link
Member Author

Ocramius commented Nov 8, 2022

Alright, 🚢, so I can work on laminas/laminas-cache-storage-adapter-apcu#45 and release that too :)

@Ocramius Ocramius merged commit 27a0adb into laminas:1.29.x Nov 8, 2022
@Ocramius Ocramius deleted the feature/#135-add-make-support-to-ci-container branch November 8, 2022 09:18
Ocramius added a commit to boesing/laminas-cache-storage-adapter-apcu that referenced this pull request Nov 8, 2022
@Ocramius
Removed apt install make, handled in laminas/laminas-continuous-int…
024c7da 
…egration-action#138

Ref: laminas/laminas-continuous-integration-action#138
Ref: laminas/laminas-continuous-integration-action#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boesing boesing Awaiting requested review from boesing

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.

Missing make command which was available in previous container versions
1 participant
@Ocramius