Raise open files limit back to ubuntu v20 values #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
The docker build on GHA led to an error that `unlimited` is not a number. Actually, the `ulimit -n` command should not return `unlimited` but `1048576` as that is what is configured in `/etc/security/limits.d/testuser.conf`. However, for the initial release, we should just trust the container. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
internalsystemerror
approved these changes
Dec 16, 2022
ghostwriter
reviewed
Dec 16, 2022
There was a problem hiding this comment.
systemd ignores the values from the /etc/security/limits.conf//etc/security/limits.d/*.
To configure a system-wide limit:
- add
DefaultLimitNOFILE=1048576to/etc/systemd/system.conffile - add
fs.file-max=1048576to/etc/sysctl.conffile
1048576 is an arbitrary value.
|
Thanks! Feel free to provide a patch for this, as of now, this change fixed all of my problems at once and thus I have no further needs for this. But if you can think about problems which might be solved with adding the other settings, I'm happy to merge patches. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of Ubuntu v22, the maximum number of open file descriptors were lowered for non-root users from
1048576to1024.This will restore the old value of
1048576which might fix some broken CI runs in thelaminas-cache-storage-adapter-*repositories, etc.