Introduce roave/backward-compatibility-check and @default php version
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
commented
Jul 8, 2023
boesing
force-pushed
the
feature/roave-backward-compatibility-check
branch
from
9fdd837
to
925297a
Compare
boesing
commented
Jul 8, 2023
|
Ready for review. |
boesing
commented
Jul 8, 2023
…vailable tool Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/roave-backward-compatibility-check
branch
from
925297a
to
97ec86f
Compare
boesing
commented
Jul 8, 2023
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
changed the title
roave/backward-compatibility-checkroave/backward-compatibility-check and @default php version
Ocramius
requested changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
roave-backward-compatibility-checkto the globally available tools.By moving
setup/staabm-annotate-pull-request-from-checkstyleinto the rootscomposer.json, we allowrenovateto automatically bump composer dependencies.By adding another GHA, we do also verify that the tools we are installing are actually executable (i.e. due to the aggressive PHP version requirements of roave packages).
@defaultforphpjob configuration will be provided by laminas/laminas-ci-matrix-action#126 once my changes were pushed (not yet possible due to PR/fork limitations).