Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.3 support #174

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Add PHP 8.3 support #174

merged 1 commit into from
Sep 3, 2023

Conversation

MauricioFauth
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Adds support for PHP 8.3.

@MauricioFauth MauricioFauth mentioned this pull request Aug 30, 2023
Merged
@MauricioFauth
Add PHP 8.3 support
ecc5dd4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@boesing
Copy link
Member

boesing commented Aug 31, 2023

Nice, thanks!
I'd like to wait until PHP 8.3 RC1 is released and built by sury (which will be today but no clue when the sury build will provide RC1 tho).

@boesing boesing added this to the 1.35.0 milestone Aug 31, 2023
@boesing
Copy link
Member

boesing commented Aug 31, 2023

https://jenkins.rfc1925.org/view/PHP%20Engine/job/php_php8.3-binaries/

Most probably, a build from 2023-08-31 or later will indicate that RC1 is available.
I try to check that page regularly to see if its available - in case I do miss it, feel free to ping me here.

Thanks for helping us here, thats really appreciated.

@MauricioFauth
Copy link
Contributor Author

Most probably, a build from 2023-08-31 or later will indicate that RC1 is available. I try to check that page regularly to see if its available - in case I do miss it, feel free to ping me here.

@boesing RC1 packages are available.

@boesing
Copy link
Member

boesing commented Sep 2, 2023

Huge. lets wait until the build has finished. I'll take care of the rebuild tomorrow or later this evening (CEST).
Thanks for pinging me ☺️

@boesing
Copy link
Member

boesing commented Sep 3, 2023

LGTM. Thanks, @MauricioFauth!

@boesing boesing merged commit 9d21d8d into laminas:1.35.x Sep 3, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 3, 2023
Merged
@MauricioFauth MauricioFauth deleted the php83-support branch September 3, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
No open projects
PHP 8.3
Status: Done
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MauricioFauth @boesing