Migrate nodejs installation to recommended by nodesource #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a 60 seconds |
|
I only found the 20 seconds sleep, those files are meanwhile removed from that repository but I built a few days ago and have seen 60 seconds. |
|
@boesing seems they went back to installation scripts |
|
@boesing is this change still needed? |
|
Jeez. Current installation fails silently to register nodesource and then default nodejs 12 is installed. Yeah, this is needed. |
See also https://github.com/nodesource/distributions#installation-instructions Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
qa/migrate-nodejs-installation
branch
from
7990ab5
to
9e015a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See also https://github.com/nodesource/distributions#installation-instructions