Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove marshalUriFromSapi function #152

Merged
merged 3 commits into from
May 2, 2023
Merged

Remove marshalUriFromSapi function #152

merged 3 commits into from
May 2, 2023

Commits on May 2, 2023

  1. refactor: remove marshalUriFromSapi function 

    Marked for removal for 3.0.0, so this patch removes it.
It also removes tests in `ServerRequestFactoryTest` that exercised it, as these had been largely moved to the `UriFactoryTest` already.
One test method was found that had not, and was moved to that factory.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c6c99a4 View commit details
    Browse the repository at this point in the history

  2. docs: update docs to note removal of marshalUriFromSapi 

    - adds a migration note
- removes reference from API documentation

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8accacf View commit details
    Browse the repository at this point in the history

  3. qa: remove psalm issue suppressions 

    Removes issue suppressions for marshalUriFromSapi and GdImage from Psalm config.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
    @weierophinney
    weierophinney committed May 2, 2023
    Configuration menu
    Copy the full SHA
    62b55c0 View commit details
    Browse the repository at this point in the history