Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "return" in aliased functions. #30

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Jan 2, 2020

Q A
Bugfix yes
BC Break no
New Feature no
RFC no

@Xerkus Xerkus added the Bug Something isn't working label Jan 2, 2020
@ADmad
Copy link
Contributor Author

ADmad commented Jan 4, 2020

Anything holding up merging this?

@Xerkus
Copy link
Member

Xerkus commented Jan 6, 2020

@ADmad more works needs to be done for those than just merge it. It is being handled.

@ADmad
Copy link
Contributor Author

ADmad commented Jan 6, 2020

@Xerkus Thanks for the update.

@weierophinney
Copy link
Member

I've reviewed, and these are present from release 1.8.0 on.

What I'll be doing is applying the patch to each release and issuing a patch release (e.g., 1.8.0p1). I've confirmed that Composer handles these properly — i.e., they take precedence over the stable tag they're applied against.

Once I've applied to all releases, I'll apply to master and issue a new bugfix release.

@ADmad
Copy link
Contributor Author

ADmad commented Jan 7, 2020

Just for reference CakePHP uses zendframework/zend-diactoros v2 and I discovered this issue when trying to switch to laminas package. The fixes I have done makes our testsuite happy.

weierophinney added a commit that referenced this pull request Jan 7, 2020
Add missing "return" in aliased functions.
weierophinney added a commit that referenced this pull request Jan 7, 2020
@weierophinney weierophinney merged commit 619b5ab into laminas:master Jan 7, 2020
weierophinney added a commit that referenced this pull request Jan 7, 2020
… develop

Forward port #30

Conflicts:
	CHANGELOG.md
@ADmad ADmad deleted the function-aliases branch January 7, 2020 19:41
@weierophinney
Copy link
Member

I've tagged 2.2.2 with the change, and issued the following patch releases:

  • 1.8.0p1
  • 1.8.1p1
  • 1.8.2p1
  • 1.8.3p1
  • 1.8.4p1
  • 1.8.5p1
  • 1.8.7p1
  • 2.0.0p1
  • 2.0.1p1
  • 2.0.2p1
  • 2.0.3p1
  • 2.1.0p1
  • 2.1.1p1
  • 2.1.2p1
  • 2.1.3p1
  • 2.1.4p1
  • 2.1.5p1
  • 2.2.0p1
  • 2.2.1p1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants