Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ABSA API to the swagger defs v3.1-Preview.1 #2

Merged
merged 55 commits into from
Mar 5, 2020

Conversation

josuhazure
Copy link

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

zfchen95 and others added 30 commits March 4, 2020 15:43
* Added redis cache Event Schema to Event Grid DP Repo

* removed commented section
* changes to get subscription

* tags for deployments

* fixes from another fork

* added extension
…ssion; add an example for IxRs directPeeringType (Azure#8517)
* initial commit with the 2019-07-01 version first

* adding the properties from the private sdk from version 2019-07-01

* adding diskIOPSReadOnly and diskMBpsReadOnly

* adding 202 response code for PUT of a DiskEncryptionSet

* adding exmaples

* updating the example for creating a disk encryption set to include the 202 response and updating the readme

* removing the 201 response code from DiskEncryptionSet creation

* updating the descrptions for the EncryptionTypes

* type is no longer required in the Encryption field for Disk Properties

* changing the readme package and description for diskmbpsreadonly and diskiopsreadonly descriptions in disk.json

* making diskMBpsReadWrite an int64

* updating the exmaples and disk.json to use the 2019-11-01 version

* removing encryptionwithcustomerkey

* adding galleryImageRef

* supressing the camelCase rule for IOPS

* fixing syntax errors in readme.md

* changing the supression file to be disk.json rather than disks.json

* adding properties to the supression paths

* updating the from field in the supression

* updating supression

* moving supression to the top

* suppressing the lint errors for IOPS

* removing diskencryptionset changes

* putting encryption type back in the disk encryption object but type is now optional

* removing encryption set type
* Update DataShare.json

* Update DataShare.json

* replace resource-manager
…zure#8243)

* New examples and swagger for all APIs related to managed server operations

* Run prittier check

* Update ListManagedInstanceOperations.json
* Added case tactics

* Added incident tactics

* Removing redundant comma from incident additional data

* Changed tabs to spaces to better match format in file

* Rename tactics field (alertTactics=>tactics)

* Rename unknown classification to undetermined classification

* Undo last commmit
* 2020-02-01-preview for Media Services LVA

Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description

* Prettier and model validations fix

* Fixing validations

* Fixing version in Common.json

* Using common types.json

* Updating new version

* Adding old version

* Revert "Adding old version"

This reverts commit 6bf3a73.

* Using common types

* Using 200 for operation locatio header.

* Fixing validation errors

* Trying to fix autorest

* Reverting common.js to test if that matters for autorest.

* Reverting default operation result to test if that matters for autorest

* Fixing previous revert.

* Fixing after merge from upstream

* Testing default operation result

* Testing description

* Adding common json back

* Testing empty description

* Testing no default for operation result

* Removing common.json

* Updating common.json of AMS

* Updating common.json

* Updating common.json

* Updating common.json

* Rename unknown classification to undetermined classification (Azure#8436)

* Fixing the structure of RESTProxy documentation:  Updating the OperationId (Azure#8327)

* Updating the OperationId

Updating the OperationId because the grouping of operations isn't correct.

* Updating the operationId spelling

* Making prettier fixes as outputed

* update lint doc, add the missed rules doc R2029,R2007 (Azure#8502)

* Linter tool document update: add R4004, modify R2016 ,R3006 (Azure#8417)

* Linter tool document update: add R4004.

* Update linter doc :  modify R2016 ,R3006

* change date format

* Update  description of R2016

* 2020 01 01 updates to rules engine caching behavior (Azure#8455)

* 2020 01 01 updates to rules engine caching behavior

* add new cache settings fields to CacheConfiguration

* cache settings fields will enable Rules Engine to allow cache override actions

* fix typos in examples

* renamed privateLinkResourceId to privateLinkAlias

* fix x-nullable usage

* Change cacheDuration to "format":"duration"

Co-authored-by: Moustafa Eid <eidmoustafa@gmail.com>

* add cli.md for postgresql (Azure#8492)

* add cli.md for postgresql

* remove  and update description

* Added minimalTlsVersion property for Managed Instance endpoint, API version 2018-06-01-preview (Azure#8508)

* [SRP] Add blob service property for container soft delete (Azure#8498)

* Adds 'Offline' state to provisioning states. (Azure#8509)

* Fix x-ms-enum name conflict (Azure#8465)

* [Deployment Scripts] Deployment scripts error model update (Azure#8481)

* add package-subscriptions-2019-11 (Azure#8503)

* regenerated all-api-versions

* Added redis cache publisher schema for azure event grid. (Azure#8486)

* Added redis cache Event Schema to Event Grid DP Repo

* removed commented section

* [Hub Generated] Review request for Microsoft.Attestation to add version preview/2018-09-01-preview (Azure#8478)

* Include Tags in GetSubscription and Deployment APIs (Azure#8268)

* changes to get subscription

* tags for deployments

* fixes from another fork

* added extension

* Remove readonly flag from microsoftSessionAddress properties in BgpSession; add an example for IxRs directPeeringType (Azure#8517)

* add cli.md for databricks (Azure#8521)

* Reverting to local Common.json to satisify autorest against md file.

* Fixing prettier

Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com>
Co-authored-by: anushreeringne <anushreeringne@users.noreply.github.com>
Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: aramesh-msft <59899320+aramesh-msft@users.noreply.github.com>
Co-authored-by: Moustafa Eid <eidmoustafa@gmail.com>
Co-authored-by: Kerwin <sunkaihuisos@gmail.com>
Co-authored-by: Andrija Cicovic <60783126+cicovica@users.noreply.github.com>
Co-authored-by: Zhenfeng <john.chan08@yahoo.com>
Co-authored-by: Akashdeep Goel <akashdeep.goel1996@gmail.com>
Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
Co-authored-by: Filiz Topatan <fitopata@microsoft.com>
Co-authored-by: Jiashuo Li <jiasli@microsoft.com>
Co-authored-by: abebts2000 <54288923+abebts2000@users.noreply.github.com>
Co-authored-by: gkostal <gkostal@microsoft.com>
Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Praneeth Sanapathi <svpraneethnaidu@gmail.com>
* async operation status

* privatelinkscope operation

* Delete operationStatuses.json

* Update privateLinkScopes_API.json

* Update privateLinkScopes_API.json

* Update privateLinkScopes_API.json
Azure#8352)

* Use common types. Fix definitions for proper .NET SDK generation.

* Use tracked and proxy resource types

* Revert reference of IdentityPatch to Identity resource

* Revert the previous revert
* Adding Swagger details for Put BackupResourceVaultConfigs call

Adding Swagger details for Put BackupResourceVaultConfigs call

* Setting feature state as Enabled

* Fixing duplicate OperationId for new Put API

* Adding default response

Co-authored-by: gcs06 <g.chandrasekarendran@gmail.com>
…PI (Azure#8276)

* Fix type conversion issue of property Version

* fix model validation

* Update code
…8368)

* adding DELETE API to applicationWhitelistings

* adding NotFound to the response

* fix whitespace

* add 404 to example

* changed 404 to 204 when group not found / already deleted

* added 202 Accepted when performing delete in the background
…ure#8525)

* Added python deployment scripts package reference

* update python sdk references
…zure#8418)

* Added missing fields and corrected enum values as per actual implementation

* Removing unsupported LineOfCredit API

Removing unsupported LineOfCredit API

* Delete IncreaseLineOfCreditBySubscription.json

* Adding additional fields to Invoicing APIs

Adding additional fields to Invoicing APIs

* Adding additional feilds to Agreements

Adding additional feilds to Agreements

* Update billing.json

* Updated descriptions

* Upodated the agreement category enum

* Updated description as per review comments.

* Correcting typo

* Updated the category enum values

* Updated enum names

* Updated

* Added "isMonthlyInvoice"

* Updated description for IsMonthlyInvoice

Updated description for IsMonthlyInvoice

* Fixed the build error

* Updated with review comments
iscai-msft and others added 25 commits March 4, 2020 15:43
* updated readmes for python sdk

* additional change
* Fix set LTR policy example

* Add resource group based LTR APIs

* fix examples

* Fix MI LTR example

* Fix example

* another minor fix
* fixing type in example

* More fixes for LTR MI example

* making fixes for restore details changes

* adding ProxyResource reference'

* update api version in example file
* Individual enrollments updates

* fixing swagger

* Making small tweaks

* Removed solution model in example

* Prettier check

* Made suggested changes

* Missing bracket

* Adding names to x-ms-enums
…ble/2020-03-01.11.0 (Azure#8546)

* Initial commit (copying old API version)

* Update data plane
…zure#8504)

* AppInsights

* OperationalInsights

* typo

* typos

* Fix most validation issues

* Fix prettier issues

* Revert changes to existing operation IDs - ignore validation warnings
* Upgrade tools script version.

Upgraded the OAV version.
…stable/2018-03-01 (Azure#7920)

* fix(metricAlert_API): add missing properties to web test metric alert

* docs(metricAlert_API): change properties description

* fix(metricAlert_API): remove templateType from webtest metric alert rules

* fix(metricAlert_API): change subscription description

* fix(metricAlert_API): prettier checks

* fix(): lint warnings

* fix(): lint warnings

* fix(): run prettier

* fix(metricAlert_API): add 'None' option to AggregationType enum in order to be align with 2018-01-01 metricDefintions_API.json

* fix(metricAlert_API): align AggregationType enum with metricDefinitions

* fix(): revert changes to un-brack ARM api

* fix(): change webTestId description

* fix(): add none to timeAggregation enum for compatbility

* fix(): remove type: string and none value from timeAggregation enum
* Update swagger for missing properties

* Revert "Update swagger for missing properties"

This reverts commit dc74330.

* Add tail query string to log route

* Add example and update description

* Update description one more time

* Fix tail type in the example
* add cli.md for storage

* update testcase
…zure#8568)

* Supporting linked storage accounts api.

* Linked storage accounts examples.

* Update examples api version.

* Get all linked storage accounts api will point to the correct example.

* Updating linked storage accounts list by workspace example.

* next link should be equal to null, more constraints on enum types.

* cspell/prettier fixes.

* Correcting enum values in examples.

* Enum value mistmatch fix.
…d PublicNetworkAccess property (Azure#8474)

* Created 2020-01-03 cosmosdb version with new PublicNetworkAccess database account property

* Updated readme.md

* Changed version number to 2020-03-01

* Added default response for DatabaseAccountGetResults

* Fixed json for DatabaseAccountGetResults

* Removing default response from DatabaseAccountGetResults

* Added 404 to DatabaseAccounts_Get

* Updated CosmosDBDatabaseAccountGet.json with 404 example
@laramume laramume merged commit 3befe3f into laramume:users/laramume/AddAPI Mar 5, 2020
"id": "1",
"sentiment": "positive",
"documentScores": {
"positive": 0.998519241809845,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we supposed to show score up to 2 decimal places?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not changed to the sentiment results yet; only aspect related results are correct so far.

laramume pushed a commit that referenced this pull request May 29, 2020
* Add encryption scope API to 2019-06-01.

Add encryption scope API to 2019-06-01.

* Address CI failures.

* Fix CI failures #2.

* Address CI failures #3.

Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
laramume pushed a commit that referenced this pull request May 29, 2020
* 2019-08-09-preview

* spell out networks

* username and credential needed to add an IdentitySource

* post listAdminCredentials

* standardize on username, password, nsxt and vcenter

* add nsxt to custom-words.txt

* default cluster does not have provisioningState

* it extends DefaultClusterProperties

* add Circuit expressRoutePrivatePeeringID

* back out some minor changes for sdk generation

* identitySources and Circuit authorizations are updateable

* add PrivateClouds_ListInSubscription

* Long running operation for Clusters_Delete (#1)

* npm run prettier

* location for all resources (#2)

* Revert "location for all resources (#2)" (#3)

This reverts commit 432e37b.

* add description TODOs

* example is PrivateClouds_Update

* require body in PrivateClouds_Update

* replaced TODOs with descriptions

* spellcheck

* "x-ms-secret": true

* Revert ""x-ms-secret": true"

This reverts commit 3358dff.

Co-authored-by: Andrew Ulliani <aulliani@yahoo.com>
Co-authored-by: Eugene Tolmachev <e.tolmachev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.