[5.4] fix eloquent collection contains issue #19568

storyn26383 · 2017-06-12T13:20:18Z

I think this pull request can fix below issue:

$post = Post::create(['id' => 1]);
$comment = Comment::create(['id' => 1]);

$collection = new EloquentCollection([$post]);

$collection->contains($comment); // expect is false, but true given

ntzm · 2017-06-12T14:53:57Z

src/Illuminate/Database/Eloquent/Collection.php

+        if ($key instanceof Model) {
+            return parent::contains(function ($model) use ($key) {
+                return $model->getKey() == $key->getKey() &&
+                       get_class($model) == get_class($key);


Can we use $model->is($key) instead if possible? That has some additional checks such as connection as well!

Thanks for advice, much better now 😜

fix eloquent collection contains issue

4ed80bf

ntzm reviewed Jun 12, 2017

View reviewed changes

storyn26383 added 2 commits June 12, 2017 23:27

use $model->is($key) instead

c766b5a

remove useless code

7fe851c

taylorotwell merged commit 3cde539 into laravel:5.4 Jun 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.4] fix eloquent collection contains issue #19568

[5.4] fix eloquent collection contains issue #19568

storyn26383 commented Jun 12, 2017 •

edited

Loading

ntzm Jun 12, 2017

storyn26383 Jun 12, 2017 •

edited

Loading

[5.4] fix eloquent collection contains issue #19568

[5.4] fix eloquent collection contains issue #19568

Conversation

storyn26383 commented Jun 12, 2017 • edited Loading

ntzm Jun 12, 2017

Choose a reason for hiding this comment

storyn26383 Jun 12, 2017 • edited Loading

Choose a reason for hiding this comment

storyn26383 commented Jun 12, 2017 •

edited

Loading

storyn26383 Jun 12, 2017 •

edited

Loading