Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Adding minRatio & maxRatio rules on Dimension validation ruleset #52482

Merged
merged 10 commits into from
Sep 5, 2024
Merged

[11.x] Adding minRatio & maxRatio rules on Dimension validation ruleset #52482

merged 10 commits into from
Sep 5, 2024

Commits on Aug 14, 2024

  1. feat(dim-ratio): add min, max & range methods to Dimensions rule

    @CamKem
    CamKem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    01dd3ff View commit details
    Browse the repository at this point in the history

  2. feat(dim-ratio): add logic for what makes a min or max failing ratio

    @CamKem
    CamKem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b0036e View commit details
    Browse the repository at this point in the history

  3. test(dim-ratio): add test for the new rules to the validator

    @CamKem
    CamKem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5f06af9 View commit details
    Browse the repository at this point in the history

  4. test(dim-ratio): add more tests for coverage for the new methods on t… 

    …he Dimension rule test
    @CamKem
    CamKem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3602d83 View commit details
    Browse the repository at this point in the history

  5. test(dim-ratio): update condition where full ratio not provided in te… 

    …st (edge-case)
    @CamKem
    CamKem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5cabd32 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. chore: styleci fixes

    @CamKem
    CamKem committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c75165c View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. formatting

    @taylorotwell
    taylorotwell committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    72ee697 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. test: added validation message test

    @CamKem
    CamKem committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7ddee9a View commit details
    Browse the repository at this point in the history

  2. test: fixed naming

    @CamKem
    CamKem committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2473c45 View commit details
    Browse the repository at this point in the history

  3. chore: styleci fixes

    @CamKem
    CamKem committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1a76fee View commit details
    Browse the repository at this point in the history