[11.x] Applying value Function into the $default value of transform helper

[devajmeireles]

The $default value of the transform function does not pass through the value to allow the execution of a closure to obtain the default value, for example. This PR fixes this by passing $default through the value helper.

[taylorotwell]

Would this be considered a breaking change?

[devajmeireles]

Would this be considered a breaking change?

I strongly believe not, since both value and transform set $default in the same way.

[rodrigopedra]

Only if someone is expecting the $default to be a callable, then instead of getting it, they would get the result of its execution.

Which, IMO, is highly unlikely.

[rodrigopedra]

@taylorotwell actually this is unneeded, re-reading my comment, I fell I oversaw it. The transform helper already checks if the $default is a callable, and if so calls it with the $value as a parameter:

framework/src/Illuminate/Support/helpers.php

Lines 468 to 479 in 81a0b5b

	function transform($value, callable $callback, $default = null)
	{
	if (filled($value)) {
	return $callback($value);
	}
	if (is_callable($default)) {
	return $default($value);
	}
	return value($default);
	}

The line modified in this PR only adds a function call to the stack call, as $default never be a callable at this point:

// $default is never a callable here
return value($default);

Other than the useless function call, there is no harm in keeping it, so I didn't send a PR to revert it.

[devajmeireles]

@taylorotwell actually this is unneeded, re-reading my comment, I fell I oversaw it. The transform helper already checks if the $default is a callable, and if so calls it with the $value as a parameter:

framework/src/Illuminate/Support/helpers.php

Lines 468 to 479 in 81a0b5b

	function transform($value, callable $callback, $default = null)
	{
	if (filled($value)) {
	return $callback($value);
	}
	if (is_callable($default)) {
	return $default($value);
	}
	return value($default);
	}

The line modified in this PR only adds a function call to the stack call, as $default never be a callable at this point:

// $default is never a callable here
return value($default);

Other than the useless function call, there is no harm in keeping it, so I didn't send a PR to revert it.

We're not just talking about callables.

[rodrigopedra]

Just to be clear, you did check the value() implementation, right?

framework/src/Illuminate/Collections/helpers.php

Lines 234 to 237 in 81a0b5b

	function value($value, ...$args)
	{
	return $value instanceof Closure ? $value(...$args) : $value;
	}

If the $value argument isn't a \Closure, this helper just returns the $value variable.

As the if clause just before the modified line excludes the possibility of $value being a callable, the line modified in this PR adds no value, and worst, just adds a function call.

We're not just talking about callables.

Now you let me curious, I guess we mutually agree that in the modified line, $value will never be a callable, and thus never be a \Closure, which excludes the \Closure path from the value() ternary implementation, right?

So, what are you talking about, then?